X-RT-Original-Encoding: utf-8
Content-Disposition: inline
Message-ID: <20171018052617.GA8139@isc.org>
Received: from bikeshed.isc.org (bikeshed.isc.org [149.20.48.19]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mail.isc.org", Issuer "RapidSSL CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id AFF6BD78B0C for <bind9-public@bugs.isc.org>; Wed, 18 Oct 2017 05:26:19 +0000 (UTC)
Received: by bikeshed.isc.org (Postfix, from userid 10292) id 1FBDC216C1E; Wed, 18 Oct 2017 05:26:17 +0000 (UTC)
References: <RT-Ticket-46289@isc.org> <rt-4.4.1-450-1508157459-1167.46289-4-0@isc.org> <rt-4.4.1-24176-1508297322-1589.46289-4-0@isc.org>
X-RT-Interface: Email
CC: 
X-Original-To: bind9-public@bugs.isc.org
Subject: Re: [ISC-Bugs #46289] Make nsec3param_salt_totext() part of public libdns API
content-type: text/plain; charset="utf-8"
In-Reply-To: <rt-4.4.1-24176-1508297322-1589.46289-4-0@isc.org>
Delivered-To: bind9-public@bugs.isc.org
Return-Path: <each@isc.org>
From: "Evan Hunt" <each@isc.org>
MIME-Version: 1.0
Date: Wed, 18 Oct 2017 05:26:17 +0000
X-RT-Incoming-Encryption: Not encrypted
To: "Mark Andrews via RT" <bind9-public@isc.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
From each@isc.org  Wed Oct 18 05:26:19 2017
RT-Message-ID: <rt-4.4.1-41896-1508304380-27.46289-0-0@isc.org>
Content-Length: 499

On Wed, Oct 18, 2017 at 03:28:43AM +0000, Mark Andrews via RT wrote:
> Made a few updates.
> 
> Ready to commit.  Note we are theoretically feature frozen for 9.12.

I'd call this [cleanup] not [func], it's not in any way a user-visible
change.

To quibble, I'd suggest moving it to lib/dns/nsec3.c and calling the
function dns_nsec3param_salttotext().  The files in lib/dns/rdata are
referenced via #include in code.c and called from lib/dns/rdata.c; it
isn't a good fit to mix other stuff there.