X-Mailer: MIME-tools 5.508 (Entity 5.508)
To: bind9-public@isc.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Message-ID: <rt-4.4.1-64974-1508425108-1724.0-0-0@isc.org>
Content-Disposition: inline
Content-Transfer-Encoding: binary
X-RT-Interface: Web
Date: Thu, 19 Oct 2017 14:58:28 +0000
From: stephen@isc.org
Subject: Extend unit tests for isc_inet_pton/isc_inet_ntop
X-RT-Original-Encoding: utf-8
Content-Length: 507

A follow-on from #46171 (add unit test for isc_inet_pton), the unit tests for these functions should be extended to check they detect invalid input and return the correct error codes.  Conditions that should be checked are:

inet_pton
* Invalid address family
* Invalid address for family (e.g. AF_INET with a V6 address)
* Invalid address in correct format (e.g. 1.2.3.456)
* NULL passed as address argument
* Empty address argument
* Invalid address argument

inet_ntop
* Buffer too small to accept result