MIME-Version: 1.0
X-RT-Interface: Web
Message-ID: <rt-4.4.1-83044-1508498414-727.46289-0-0@isc.org>
X-Mailer: MIME-tools 5.508 (Entity 5.508)
In-Reply-To: <rt-4.4.1-41896-1508304380-27.46289-0-0@isc.org>
X-RT-Original-Encoding: utf-8
Content-Transfer-Encoding: binary
Content-Disposition: inline
References: <RT-Ticket-46289@isc.org>
 <rt-4.4.1-450-1508157459-1167.46289-4-0@isc.org>
 <rt-4.4.1-24176-1508297322-1589.46289-4-0@isc.org>
 <20171018052617.GA8139@isc.org>
 <rt-4.4.1-41896-1508304380-27.46289-0-0@isc.org>
Content-Type: text/plain; charset="utf-8"
RT-Send-CC:
Content-Length: 895

> I'd call this [cleanup] not [func], it's not in any way a user-visible
> change.

Agreed.  Is this already annotated as [func] anywhere?  rt46289 does not
seem to include a CHANGES update.  Did you just mean to point this out
_before_ CHANGES is updated?

> To quibble, I'd suggest moving it to lib/dns/nsec3.c and calling the
> function dns_nsec3param_salttotext().  The files in lib/dns/rdata are
> referenced via #include in code.c and called from lib/dns/rdata.c; it
> isn't a good fit to mix other stuff there.

Good point.  I think I originally put it into lib/dns/rdata because that
is what Mukund suggested in passing on Jabber and I have not bothered to
look around the tree for a better fit.  The changes I just pushed to
rt46289 address your comments, merge nsec3param_test.c into nsec3_test.c
and do some naming bikeshedding.  No functional changes were introduced.
Please review.