MIME-Version: 1.0 Date: Tue, 24 Oct 2017 14:29:23 +0000 Subject: Fix/Extend testing for dnssec-cds From: stephen@isc.org Content-Type: text/plain; charset="utf-8" X-Mailer: MIME-tools 5.508 (Entity 5.508) To: bind9-public@isc.org Content-Transfer-Encoding: binary Message-ID: Content-Disposition: inline X-RT-Interface: Web X-RT-Original-Encoding: utf-8 Content-Length: 978 Reviewed the testing of the utility at commit b49042a6a5e7fd21f2147337c21a5d4d9b957204 (on master, post V9.12.0b1). Overall, the utility has a comprehensive set of tests. The following points should be addressed however: 1. The tests fail on FreeBSD-11. (This appears to be a peculiarity of the test script, not of the utility itself.) 2. There is no test for the operation of the "-c" switch (class of the zones). 3. Tests should check that "-s " outputs an error message when is not a valid date and time. 4. The tests only check -s with relative times, not absolute times. 5. Tests should check that "-T " outputs an error message when is not a valid TTL. 6. The algorithms tested are SHA1 and SHA256. The documentation states that the utility can also use GOST and SHA384 - these two should be tested as well. 7. No check is made that the algorithm argument is interpreted in a case-insensitive manner. 8. There is no test for the -V switch