Subject: possible configure script error in finding zlib library
From: "Brian Meyer" <brian@cardadmin.com>
To: bind-bugs@isc.org, dhcp-bugs@isc.org
Content-Transfer-Encoding: quoted-printable
From brian@cardadmin.com  Mon Nov  6 22:57:21 2017
content-type: text/plain; charset="utf-8"
Message-ID: <0DA2B7B2-81B2-4452-924A-7C817D7E7A40@cardadmin.com>
MIME-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
X-Virus-Scanned: amavisd-new at zmail.cardadmin.com
Date: Mon, 6 Nov 2017 14:56:31 -0800
Return-Path: <brian@cardadmin.com>
X-Mailer: Apple Mail (2.1878.6)
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org
X-RT-Original-Encoding: ascii
X-RT-Interface: Email
Content-Length: 1972

downloaded 
ftp://ftp.isc.org/isc/bind9/9.11.2/bind-9.11.2.tar.gz

Then I did a standard gnu make install to make it's libraries available on my mac system in a safe place that won't affect my actual system.

I was using the --with-zlib and it did not seem to be taking it. I have everything compiling in a custom prefix location named "/agility" so usually I can use "--with-zlib=/agility".

I noticed that in the following code ( at about 17326 in ./configure ) that when I added an echo of the variable being tested, it said "TESTING/agility/zlib.h" and thus it isn't being found, the file in question is actually in "/agility/include/zlib.h"

However after that it is after that setting zlib_cflags="-I${with_zlib}/include", and LIBS="$LIBS -L${with_zlib}/lib", so it really wants the file in include, hence this code can never work.

It would have to be in the root of agility to configure it, and if so it sets up an include path for two subdirectories which it would need to compile it.

I edited the source file to if test -f "${with_zlib}/include/zlib.h" so the variable with_zlib is the root, and it matches the other usage in  zlib_cflags="-I${with_zlib}/include", this seems to be working. I suggest adjusting the source to reflect this.

Here is the code in question

have_zlib=""
case "$with_zlib" in
	no)
		zlib_libs=""
		;;
	auto|yes)
		for d in /usr /usr/local /opt/local
		do
			if test -f "${d}/include/zlib.h"
			then
				if test ${d} != /usr
				then
					zlib_cflags="-I ${d}/include"
					LIBS="$LIBS -L${d}/lib"
				fi
				have_zlib="yes"
			fi
		done
		;;
	*)
		echo TESTING  "${with_zlib}/zlib.h"   <-- this is my debugging to see what is going on
		
		if test -f "${with_zlib}/zlib.h"  <---- this is the bug, it should be  "${with_zlib}/include/zlib.h"
		then
			zlib_cflags="-I${with_zlib}/include"
			LIBS="$LIBS -L${with_zlib}/lib"
			have_zlib="yes"
		else
			as_fn_error $? "$with_zlib/include/zlib.h not found." "$LINENO" 5
		fi
		;;
esac