From: "Evan Hunt" <each@isc.org>
X-Original-To: bind9-public@bugs.isc.org
Return-Path: <each@isc.org>
To: "Michał Kępień via RT" <bind9-public@isc.org>
From each@isc.org  Wed Nov  8 16:33:41 2017
X-RT-Interface: Email
MIME-Version: 1.0
X-RT-Original-Encoding: utf-8
Message-ID: <20171108163341.GA51860@isc.org>
CC: 
Date: Wed, 8 Nov 2017 16:33:41 +0000
content-type: text/plain; charset="utf-8"
Subject: Re: [ISC-Bugs #46520] configure —use-inline-buffer=yes
X-RT-Incoming-Encryption: Not encrypted
References: <RT-Ticket-46520@isc.org> <rt-4.4.1-77598-1510099427-899.46520-4-0@isc.org> <rt-4.4.1-46601-1510103794-847.46520-4-0@isc.org> <rt-4.4.1-46601-1510141133-1725.46520-4-0@isc.org>
In-Reply-To: <rt-4.4.1-46601-1510141133-1725.46520-4-0@isc.org>
Received: from bikeshed.isc.org (bikeshed.isc.org [149.20.48.19]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mail.isc.org", Issuer "RapidSSL CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id CC4B4D78B0A for <bind9-public@bugs.isc.org>; Wed,  8 Nov 2017 16:33:41 +0000 (UTC)
Received: by bikeshed.isc.org (Postfix, from userid 10292) id 8F37C216C1C; Wed,  8 Nov 2017 16:33:41 +0000 (UTC)
Delivered-To: bind9-public@bugs.isc.org
User-Agent: Mutt/1.5.23 (2014-03-12)
Content-Disposition: inline
RT-Message-ID: <rt-4.4.1-94889-1510158822-810.46520-0-0@isc.org>
Content-Length: 622

> Thus, I would rather report this upstream (possibly fixing the dnsperf
> copy in contrib/) than add a configure option to BIND as a workaround.
> Am I missing something?

I think originally dnsperf was building fine, then we turned on
ISC_BUFFER_USEINLINE in buffer.h and it started emitting a warning,
then we turned it into a boolean value and it broke completely.

Being performance-sensitive, it was reasonable for dnsperf to use
this option, and it remains reasonable even if libisc isn't built
with it.

I'm fine with reporting it upstream and fixing it in contrib but
I also think this is a good change to make.