From muks@isc.org Fri Nov 10 22:09:52 2017 Content-Disposition: inline X-RT-Incoming-Encryption: Not encrypted Date: Sat, 11 Nov 2017 06:09:28 +0800 X-RT-Interface: Email Return-Path: User-Agent: Mutt/1.9.1 (2017-09-22) X-Original-To: bind9-public@bugs.isc.org Message-ID: <20171110220928.GA9172@ponyo.lan.banu.com> To: "Mark Andrews via RT" Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id A71ADD78B0A for ; Fri, 10 Nov 2017 22:09:52 +0000 (UTC) Received: from mail.banu.com (mail.banu.com [46.4.129.225]) by mx.pao1.isc.org (Postfix) with ESMTP id 66CB53B6DE1 for ; Fri, 10 Nov 2017 22:09:39 +0000 (UTC) Received: from ponyo.lan.banu.com (unknown [42.61.208.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.banu.com (Postfix) with ESMTPSA id BEAD156A0389; Fri, 10 Nov 2017 22:09:33 +0000 (GMT) In-Reply-To: X-RT-Original-Encoding: utf-8 MIME-Version: 1.0 From: "Mukund Sivaraman" Subject: Re: [ISC-Bugs #46553] rbt_test:insert_and_delete is wrong. X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org content-type: text/plain; charset="utf-8" References: Delivered-To: bind9-public@bugs.isc.org RT-Message-ID: Content-Length: 513 On Fri, Nov 10, 2017 at 05:03:54AM +0000, Mark Andrews via RT wrote: > insert_and_delete calls dns_rbt_addname which updates node->data on > ISC_R_EXISTS and then returns ISC_R_SUCCESS. This results in the > expected node count not matching the reported node count. The branch looks good and is correct. The previous code was incorrect. Was this case reached btw? It looks very unlikely that two 32-byte long random alphabetic names will have a collision when 1024 names are inserted into the tree. Mukund