X-RT-Original-Encoding: utf-8 Message-ID: In-Reply-To: X-Mailer: MIME-tools 5.508 (Entity 5.508) Content-Disposition: inline Content-Type: text/plain; charset="utf-8" References: MIME-Version: 1.0 X-RT-Interface: Web Content-Transfer-Encoding: binary RT-Send-CC: Content-Length: 897 On Fri Nov 24 13:16:32 2017, stephen wrote: > The consensus on my last question is that it wasn't an issue - ports > will be bound before being used. So nothing has been changed in this > respect. > > This ticket is now ready for first review. As parallelising all the > tests will change a large number of files, I'd prefer to get a review > done of the framework changes and the few tests that have already been > converted before proceeding with the rest of the changes. Ack. Especially the changes in tests.sh gets confusing as there's a lot of replacements. > I suggest that the review first start with bin/tests/system/README. > This has been more or less completely rewritten, and should provide > context for the review of the remaining files. I attached my comments here: https://gitlab.isc.org/BIND/bind9/merge_requests/7 But it needs one more reviewer as I am co-author of this.