To: "Mark Andrews via RT" From muks@isc.org Tue Nov 28 07:05:00 2017 Return-Path: Delivered-To: bind9-public@bugs.isc.org X-RT-Interface: Email Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 3E443D78B0A for ; Tue, 28 Nov 2017 07:05:00 +0000 (UTC) Received: from mail.banu.com (mail.banu.com [IPv6:2a01:4f8:140:644b::225]) by mx.pao1.isc.org (Postfix) with ESMTP id 412373B4B35 for ; Tue, 28 Nov 2017 07:04:54 +0000 (UTC) Received: from jurassic.lan.banu.com (unknown [115.117.161.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.banu.com (Postfix) with ESMTPSA id ABDBE56A0782; Tue, 28 Nov 2017 07:04:51 +0000 (GMT) MIME-Version: 1.0 References: Message-ID: <20171128070446.GA11657@jurassic.lan.banu.com> In-Reply-To: X-Original-To: bind9-public@bugs.isc.org From: "Mukund Sivaraman" X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org X-RT-Incoming-Encryption: Not encrypted X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 Date: Tue, 28 Nov 2017 12:34:46 +0530 X-RT-Original-Encoding: utf-8 content-type: text/plain; charset="utf-8" User-Agent: Mutt/1.9.1 (2017-09-22) Content-Disposition: inline Subject: Re: [ISC-Bugs #46709] isc_heap_delete not clearing index value RT-Message-ID: Content-Length: 338 Now that isc_heap_delete() calls ->index(), is the change to rbtdb.c @@ setsigningtime() still required? The change to isc_heap_delete() and testcase looks ok. In the testcase, I'd assert e1.index != 0 in the first case as asserting index 1 looks for implementation detail. But that's just IMO.. it look fine other than that. Mukund