From: "Mark Andrews" From marka@isc.org Tue Nov 28 07:38:12 2017 To: bind9-public@isc.org Delivered-To: bind9-public@bugs.isc.org Return-Path: X-RT-Original-Encoding: utf-8 X-Original-To: bind9-public@bugs.isc.org X-Mailer: Apple Mail (2.3273) Subject: Re: [ISC-Bugs #46709] isc_heap_delete not clearing index value In-Reply-To: MIME-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Message-ID: <2AE2D2EA-7152-44A9-933C-647DE6A9061C@isc.org> References: <20171128070446.GA11657@jurassic.lan.banu.com> content-type: text/plain; charset="utf-8" X-RT-Interface: Email Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 2B982D78B0B for ; Tue, 28 Nov 2017 07:38:12 +0000 (UTC) Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 193483B4BE7 for ; Tue, 28 Nov 2017 07:38:10 +0000 (UTC) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id BC284160047 for ; Tue, 28 Nov 2017 07:38:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 86381160068 for ; Tue, 28 Nov 2017 07:38:08 +0000 (UTC) Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id wiJnUewwzhpT for ; Tue, 28 Nov 2017 07:38:08 +0000 (UTC) Received: from [172.30.42.89] (c27-253-115-14.carlnfd2.nsw.optusnet.com.au [27.253.115.14]) by zmx1.isc.org (Postfix) with ESMTPSA id 0282D160047 for ; Tue, 28 Nov 2017 07:38:07 +0000 (UTC) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 Content-Transfer-Encoding: quoted-printable X-RT-Incoming-Encryption: Not encrypted Date: Tue, 28 Nov 2017 18:38:05 +1100 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org RT-Message-ID: Content-Length: 697 > On 28 Nov 2017, at 6:05 pm, Mukund Sivaraman via RT wrote: > > Now that isc_heap_delete() calls ->index(), is the change to rbtdb.c @@ > setsigningtime() still required? No. Changing that is followup work. > The change to isc_heap_delete() and testcase looks ok. In the testcase, > I'd assert e1.index != 0 in the first case as asserting index 1 looks > for implementation detail. But that's just IMO.. it look fine other than > that. > > Mukund > > > > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46709 -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org