X-Mailer: MIME-tools 5.508 (Entity 5.508) Message-ID: In-Reply-To: X-RT-Original-Encoding: utf-8 Content-Transfer-Encoding: binary MIME-Version: 1.0 X-RT-Interface: Web References: Content-Type: text/plain; charset="utf-8" Content-Disposition: inline RT-Send-CC: Content-Length: 687 On Thu Nov 23 14:07:49 2017, fdupont wrote: > I reviewed the code: > - I pushed a few cosmetics stuff, please pull and review them > Looks good, thanks. > - I have a question which IMHO requires an answer: > when T1 and T2 are not zero or derived from lifetimes > I think they should be reduced? Note this is really specific > to DHCPv6 as for DHCPv4 this is only one timer doing > everything. > > My concern is the the threshold is a bit high after a reuse > the returned T1/T2 can (mis)lead too far. Good catch. I modified shorten_lifetimes() to update the reply minimum values which are used later on to calculate T1/T2. Seems to work just fine. Please re-review.