X-RT-Interface: Web
Message-ID: <rt-4.4.1-17677-1511907969-1460.46718-0-0@isc.org>
References: <rt-4.4.1-8816-1511877037-1497.0-0-0@isc.org>
 <RT-Ticket-46718@isc.org>
 <rt-4.4.1-58076-1511877252-1630.46718-0-0@isc.org>
Content-Transfer-Encoding: binary
MIME-Version: 1.0
Content-Disposition: inline
X-RT-Original-Encoding: utf-8
Content-Type: text/plain; charset="utf-8"
In-Reply-To: <rt-4.4.1-58076-1511877252-1630.46718-0-0@isc.org>
X-Mailer: MIME-tools 5.508 (Entity 5.508)
RT-Send-CC:
Content-Length: 706

On Tue Nov 28 13:54:12 2017, michal wrote:
> Please review rt46718 which applies a number of fixes, tweaks and
> cleanups to LMDB-related code.  Suggestions regarding naming and
> placement of DNS_LMDB_* constants (see commit 1970f078cf) are welcome.

While we are touching the code: 

a) Please refactor the configure_newzones function to eliminate duplicate code (the for loops looks identical to me) and probably result2 error code might need to be handled.  The double cleanup gotos also doesn't look very convincing.

b) A comment why failed data_to_cfg in the first loop results into running the same loop again would be useful too.

The rest looks sane.  Thanks.

Please reassign back when finished.