Content-Disposition: inline MIME-Version: 1.0 X-Mailer: MIME-tools 5.508 (Entity 5.508) X-RT-Original-Encoding: utf-8 Content-Transfer-Encoding: binary X-RT-Interface: Web In-Reply-To: Message-ID: Content-Type: text/plain; charset="utf-8" References: RT-Send-CC: Content-Length: 698 On Wed Nov 29 14:41:21 2017, michal wrote: > The two for loops you mentioned do different things. However, I agree > the purpose of this code is hard to grasp in its current form. > > I am intentionally not telling you what the code does; please look at > the few refactoring commits I just pushed to rt46718 and let me know if > it is clear now. If it is not, even more comments are likely due. Ah, it's much better now. Just one nit - why struct and not va_list (or just pass all four arguments) for the callback? The callback_data makes sense when you need to store the callback_data in an async structure. (Actually it's not a 'callback' but a function that does things directly, right?)