Message-ID: <rt-4.4.1-36279-1512045981-211.46718-0-0@isc.org>
In-Reply-To: <rt-4.4.1-21016-1512044908-747.46718-0-0@isc.org>
Content-Transfer-Encoding: binary
References: <RT-Ticket-46718@isc.org>
 <rt-4.4.1-8816-1511877037-1497.46718-4-0@isc.org>
 <rt-4.4.1-8816-1511966481-1199.46718-4-0@isc.org>
 <rt-4.4.1-8816-1511968062-1074.46718-4-0@isc.org>
 <rt-4.4.1-15072-1511979113-1036.46718-4-0@isc.org>
 <7c847a1e-32fb-6b09-9886-1ea5ec7f7015@isc.org>
 <rt-4.4.1-20585-1511992308-530.46718-0-0@isc.org>
 <rt-4.4.1-15072-1512028872-133.46718-0-0@isc.org>
 <rt-4.4.1-21730-1512042858-793.46718-0-0@isc.org>
 <rt-4.4.1-21016-1512044908-747.46718-0-0@isc.org>
X-Mailer: MIME-tools 5.508 (Entity 5.508)
X-RT-Original-Encoding: utf-8
Content-Disposition: inline
X-RT-Interface: Web
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
RT-Send-CC:
Content-Length: 780

On Thu Nov 30 12:28:28 2017, michal wrote:
> > A really minor nit, I would personally prefer to replace:
> >
> > if (!commit || result != ISC_R_SUCCESS) {
> >
> > with
> >
> > if ((commit == NULL)[1] || (result != ISC_R_SUCCESS)[2]) {
> >
> > with this explanation:
> >
> > [1] to be consistent with rest of code where we use 'text != NULL'
> > (as an example from this commit
> 
> But "commit" is a boolean here.

Ah, ok, I haven't checked.

> > [2] And the parentheses while not necessary just contributes to
> > readability and prevents future mistakes.
> 
> This is not documented in our current coding style guidelines, so I
> decided against doing this.  Naturally, we can further discuss this
> suggestion elsewhere.

Ok, I'll add this to my All-Hands coding style updates.