X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1
Return-Path: <marka@isc.org>
X-RT-Original-Encoding: utf-8
References: <RT-Ticket-46739@isc.org> <rt-4.4.1-36279-1512060028-1808.46739-4-0@isc.org> <rt-4.4.1-21016-1512098146-293.46739-4-0@isc.org> <rt-4.4.1-21016-1512136247-1209.46739-4-0@isc.org> <20171201192705.GA78105@isc.org> <rt-4.4.1-21016-1512156427-1037.46739-4-0@isc.org>
content-type: text/plain; charset="utf-8"
X-Mailer: iPhone Mail (15B202)
Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 8C698D78B0A for <bind9-public@bugs.isc.org>; Fri,  1 Dec 2017 21:52:26 +0000 (UTC)
Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id D46793B57C1 for <bind9-public@isc.org>; Fri,  1 Dec 2017 21:52:24 +0000 (UTC)
Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id 9E42816005C for <bind9-public@isc.org>; Fri,  1 Dec 2017 21:52:24 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 6CCD816007F for <bind9-public@isc.org>; Fri,  1 Dec 2017 21:52:24 +0000 (UTC)
Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id M67SCJf9gNPb for <bind9-public@isc.org>; Fri,  1 Dec 2017 21:52:24 +0000 (UTC)
Received: from [172.30.42.88] (c27-253-115-14.carlnfd2.nsw.optusnet.com.au [27.253.115.14]) by zmx1.isc.org (Postfix) with ESMTPSA id 04CCB16005C for <bind9-public@isc.org>; Fri,  1 Dec 2017 21:52:24 +0000 (UTC)
Message-ID: <831D67E9-85E5-4B40-9519-D5ED9B919AFA@isc.org>
Date: Sat, 2 Dec 2017 08:52:19 +1100
From marka@isc.org  Fri Dec  1 21:52:26 2017
X-RT-Interface: Email
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org
Subject: Re: [ISC-Bugs #46739] rndc leaks memory
MIME-Version: 1.0 (1.0)
Delivered-To: bind9-public@bugs.isc.org
To: bind9-public@isc.org
From: "Mark Andrews" <marka@isc.org>
In-Reply-To: <rt-4.4.1-21016-1512156427-1037.46739-4-0@isc.org>
X-RT-Incoming-Encryption: Not encrypted
Content-Transfer-Encoding: quoted-printable
X-Original-To: bind9-public@bugs.isc.org
RT-Message-ID: <rt-4.4.1-21016-1512165147-1975.46739-0-0@isc.org>
Content-Length: 608

On 2 Dec 2017, at 06:27, Evan Hunt via RT <bind9-public@isc.org> wrote:

>> Reviewed, tested and merged to master and 9.11
> 
> Is this all of it?  It looked like there were a lot more memory
> leaks than just the requests from the report you posted.

When you have message with lots of individually allocated components hanging off it doing a recursive cleanup of the message cleans up all the components.  If you looked at any of the leaks it was the caller that was failing to clean up. Then looking at the caller of the caller etc.  It was just a matter of finding the callers that didn’t clean up.