Date: Wed, 06 Dec 2017 16:07:22 +0100 Delivered-To: dhcp-confidential@bugs.isc.org X-RT-Original-Encoding: utf-8 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) X-RT-Interface: Email In-Reply-To: (Thomas Markwalder via's message of "Wed, 06 Dec 2017 14:24:51 +0000") MIME-Version: 1.0 Subject: Re: [ISC-Bugs #46767] [PATCH] DHCPd leaks sockets descriptors To: "Thomas Markwalder via RT" From: "Pavel Zhukov" X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org X-Spam-Status: No, score=0.5 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM autolearn=no autolearn_force=no version=3.4.1 content-type: text/plain; charset="utf-8" X-GM-Message-State: AKGB3mKfiV1czUJTxHfQTp26qH2ccIXGqfVNICDLpDOysoIrHMs5JJ3F sNVDIVU3wI5jvE9UBklaaD98FGlsjCk= Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id DB331D78B0B for ; Wed, 6 Dec 2017 15:07:27 +0000 (UTC) Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id A54283B3155 for ; Wed, 6 Dec 2017 15:07:25 +0000 (UTC) Received: by mail-wm0-f46.google.com with SMTP id f9so7746655wmh.0 for ; Wed, 06 Dec 2017 07:07:25 -0800 (PST) Received: from pzhukov-workstation.usersys.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id p42sm3300319wrb.28.2017.12.06.07.07.23 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Dec 2017 07:07:23 -0800 (PST) X-Received: by 10.28.168.88 with SMTP id r85mr13158303wme.63.1512572843928; Wed, 06 Dec 2017 07:07:23 -0800 (PST) X-Google-SMTP-Source: AGs4zMbSqYUhTchHBJ/bpt4NHdmvKYevBaE5zAbWY74wQIfSpJZA0mR/Fm8X+jC4BIjR6VpoMTUhww== X-RT-Incoming-Encryption: Not encrypted Message-ID: <87374nc2tx.fsf@pzhukov-workstation.usersys.redhat.com> From pzhukov@redhat.com Wed Dec 6 15:07:28 2017 X-Original-To: dhcp-confidential@bugs.isc.org Return-Path: X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Nu/c3Df9OKcIjcvwl1QYmXashFIiAbcRdz6pjyUgD50=; b=S90bjQmy3atbIetaWK2wycyw5FnKcutGuJhEPWW6MYfzli4n8EV5BaWuqwN82PAGHA qqDJWtmovbqaFD3ixTQ36ETg5wg3bUvAV0eRRFiY5RYy3D3og6T576XqYi7O7Q59xjOG tAolyPIP46mQmd9tOnb7vL8QDwxsfFewmP7fhE1GRaPEItQcRbyvni14s9ADNQkAW15f 70NCtpEgrSQoXetkzNIdfNTGoh0kF/MKEMhCrSoUZK2fFmMMtTjMb1UUIiS4OU1Wq9jV NZ/z49TKBbMfgbY5cI1FJpa6eQR7n9/hSPdk3wNQg8VITfz+hnOZI5qeStR8XQRUWD0o e0aQ== References: <87d13ucw5p.fsf@pzhukov-workstation.usersys.redhat.com> <87bmjcas15.fsf@pzhukov-workstation.usersys.redhat.com> RT-Message-ID: Content-Length: 954 "Thomas Markwalder via RT" writes: > Hello Pavel: > > We were able to reproduce it under Fedora 23. Ubuntu and Centos 7 > seem to be immune. We have an alternative patch that is under review > and can forward it to you for testing once reviewed. Reproduced with Centos 7 # rpm -q dhcp dhcp-4.2.5-58.el7.centos.x86_64 # lsof | grep dhcpd | grep TCP | wc -l 191 # omshell > server localhost > port 7911 > connect dhcpctl_connect: no more Note: in case of virtual environment with virtio drivers and local to dhcpd traffic the issue is not reproducible. > > Our testing here with 4.3.3 under Fedora does confirm an eventual > inability to make further OMAPI connections, but the server does > continue to service DHCP clients. The code limits the number of open > FDs to 200. As 4.2* is EOL, we did not test it, though same patch > could be applied to it. > > Regards, > > Thomas Markwalder > ISC Sofware Engineering