X-RT-Interface: Email Content-Transfer-Encoding: quoted-printable User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 References: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org content-type: text/plain; charset="utf-8" X-RT-Original-Encoding: utf-8 In-Reply-To: X-RT-Incoming-Encryption: Not encrypted Content-Language: en-US From: "Ray Bellis" Message-ID: <3e70b11d-8af0-559f-e158-8a62993b9051@isc.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 MIME-Version: 1.0 Delivered-To: bind9-public@bugs.isc.org Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id 27829D78B0D for ; Mon, 18 Dec 2017 14:21:25 +0000 (UTC) Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 00DCF3AC7EC for ; Mon, 18 Dec 2017 14:20:18 +0000 (UTC) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id C060216006B for ; Mon, 18 Dec 2017 14:20:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id A869C16006A for ; Mon, 18 Dec 2017 14:20:17 +0000 (UTC) Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OrnrnsbPddQ7 for ; Mon, 18 Dec 2017 14:20:17 +0000 (UTC) Received: from rays-mbp.local (46-227-151-81.customer.gigaclear.net [46.227.151.81]) by zmx1.isc.org (Postfix) with ESMTPSA id 48EAA160050 for ; Mon, 18 Dec 2017 14:20:17 +0000 (UTC) Return-Path: X-Original-To: bind9-public@bugs.isc.org Subject: Re: [ISC-Bugs #46435] Duplicate zone names in NZF Date: Mon, 18 Dec 2017 14:20:15 +0000 From ray@isc.org Mon Dec 18 14:21:25 2017 To: bind9-public@isc.org RT-Message-ID: Content-Length: 1609 On 15/12/2017 21:37, Mark Andrews via RT wrote: > Ready for review. Of the two cases where cfg_parser_mapadd is called only one needed reversal on failure. Build error with --enable-developer on FC27: gcc -I/home/ray/src/bind9 -I../.. -I./include -I./unix/include -I. -I/home/ray/src/bind9/lib/ns/include -I../../lib/ns/include -I/home/ray/src/bind9/lib/dns/include -I../../lib/dns/include -I/home/ray/src/bind9/lib/bind9/include -I../../lib/bind9/include -I/home/ray/src/bind9/lib/isccfg/include -I../../lib/isccfg/include -I/home/ray/src/bind9/lib/isccc/include -I../../lib/isccc/include -I/home/ray/src/bind9/lib/isc/include -I../../lib/isc -I../../lib/isc/include -I../../lib/isc/unix/include -I../../lib/isc/pthreads/include -I../../lib/isc/x86_32/include -I../../contrib/dlz/drivers/include -I/home/ray/src/bind9/unit/atf/include -D_REENTRANT -DCONTRIB_DLZ -DDLZ_FILESYSTEM -DOPENSSL -DISC_MEM_DEFAULTFILL=1 -DISC_LIST_CHECKINIT=1 -DNS_HOOKS_ENABLE=1 -D_GNU_SOURCE -DNS_HOOKS_ENABLE=1 -g -O2 -I/usr/include/libxml2 -fPIC -W -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wformat -Wpointer-arith -fno-strict-aliasing -fno-delete-null-pointer-checks -Wshadow -Werror \ -DPRODUCT=\""BIND"\" \ -DVERSION=\"9.13.0-dev\" -c ./server.c ./server.c: In function ‘do_addzone’: ./server.c:12758:16: error: declaration of ‘tresult’ shadows a previous local [-Werror=shadow] isc_result_t tresult; ^~~~~~~ ./server.c:12606:23: note: shadowed declaration is here isc_result_t result, tresult; ^~~~~~~ cc1: all warnings being treated as errors