References: <rt-4.4.1-81295-1513375456-932.0-0-0@isc.org>
 <RT-Ticket-46859@isc.org>
 <rt-4.4.1-99844-1513614800-1872.46859-0-0@isc.org>
X-RT-Original-Encoding: utf-8
Content-Disposition: inline
X-Mailer: MIME-tools 5.508 (Entity 5.508)
MIME-Version: 1.0
Message-ID: <rt-4.4.1-37631-1513708017-1815.46859-0-0@isc.org>
Content-Type: text/plain; charset="utf-8"
In-Reply-To: <rt-4.4.1-99844-1513614800-1872.46859-0-0@isc.org>
Content-Transfer-Encoding: binary
X-RT-Interface: Web
RT-Send-CC:
Content-Length: 816

On Mon Dec 18 16:33:20 2017, tmark wrote:
> Ticket is ready for review.

=> the code fix is OK even it will be fine IMHO to
change the no_dhcpd_xxx into have_dhcpd_xxx
to reflect their real meanings.

I have some concerns about the manual:
 - if by path  you mean the result of dirname you should
  add "directory", i.e.: the absolute path and file name ->
   the absolute directory path and file name
  Note this stays against usage: this is named the
  absolute path.
   
 - in the precedence:
  lease-file-name -> lease-file-name configuration file statement
  -lf flag -> -lf command line flag

 - the requirement about the path can't be understood.
  More, I don't think it is true: the only constraint is the
  statement value must be an absolute path so it can be
  evaluated and opened after the chdir("/").