Content-Disposition: inline
Content-Transfer-Encoding: binary
Content-Type: text/plain; charset="utf-8"
X-RT-Original-Encoding: utf-8
X-Mailer: MIME-tools 5.508 (Entity 5.508)
MIME-Version: 1.0
In-Reply-To: <rt-4.2.8-62213-1485427934-1350.0-0-0@isc.org>
X-RT-Interface: Web
Message-ID: <rt-4.4.1-40135-1513772901-462.44535-0-0@isc.org>
References: <rt-4.2.8-62213-1485427934-1350.0-0-0@isc.org>
 <RT-Ticket-44535@isc.org>
RT-Send-CC:
Content-Length: 793

Next patches:
 - Relay v4:
   * I kept the patching of the first 67 (index 8)

   * BTW the cast to short in ntohs() calls is
    not correct (fixed them around modified code)

   * I added a #error in other PF code (NDLI, NIT, etc)

   * missing trailing ']' in "[-p <port> | -rp <relay-port>"

  - Relay v6:
   * changed {up, down}_intf into {up, down}done

   * I am not convinced by the else before the break
    which matches more than needed but I don't believe
    it can harm so I didn't try to fix it.
   (down_intf++; in you patch)

   * changed "ipv6-relay-port" in "relay-source-port"
    and 90 in 135 and I reordered entries to increasing codes.

   * 547 -> htons(547) (compare to client_port)

   * relay-port -> relay-source-port in message

I updated the manual page.