MIME-Version: 1.0
X-Mailer: MIME-tools 5.508 (Entity 5.508)
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Message-ID: <rt-4.4.1-72722-1513987565-953.44535-0-0@isc.org>
Content-Transfer-Encoding: binary
X-RT-Interface: Web
References: <rt-4.2.8-62213-1485427934-1350.0-0-0@isc.org>
 <RT-Ticket-44535@isc.org>
 <rt-4.4.1-77314-1513958700-959.44535-0-0@isc.org>
In-Reply-To: <rt-4.4.1-77314-1513958700-959.44535-0-0@isc.org>
X-RT-Original-Encoding: utf-8
RT-Send-CC:
Content-Length: 904

On Fri Dec 22 16:05:00 2017, tmark wrote:
> relay/dhcrelay.c
>   -6 usage at line 168 does not list "-rp <relay-port>"

=> fixed.

> The man page entry should probably mention that option code values
> we're using and that the feature is "experimental".  Is it worth
> mentioning the RFC draft # as well?

=> I did this in the RELNOTES entry which is still temporary
and should be finished before the code freeze.
For the I-D full name I have done this since the period when
I-Ds were removed from the repository on update or expire...

> Building with and without --relay-port, unit tests all pass as do ISC
> DHCP specific Forge tests.  None of these tests excersize dhcrelay
> though.

=> Relay is an essential feature on both DHCPv4 and DHCPv6 so
I believe you mean dhcrelay itself.

> I think you're ok to merge.

=> Merge to master with a temporary RELNOTES entry.
See this next Friday/month/year?