Return-Path: References: <20180108182629.GA16112@jurassic> <20180118035440.GA29430@jurassic> Message-ID: X-Mailer: Apple Mail (2.3273) From marka@isc.org Thu Jan 18 23:06:39 2018 X-Original-To: bind9-public@bugs.isc.org From: "Mark Andrews" Delivered-To: bind9-public@bugs.isc.org X-RT-Original-Encoding: utf-8 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org Subject: Re: [ISC-Bugs #46966] Don't re-use nonce when processing multiple rndc requests on same connection MIME-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) content-type: text/plain; charset="utf-8" Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id B30CED78B0D for ; Thu, 18 Jan 2018 23:06:39 +0000 (UTC) Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 4BC723AB631 for ; Thu, 18 Jan 2018 23:06:37 +0000 (UTC) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id 1902316008A for ; Thu, 18 Jan 2018 23:06:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 0572C16008C for ; Thu, 18 Jan 2018 23:06:36 +0000 (UTC) Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uWe0EiEuWbdd for ; Thu, 18 Jan 2018 23:06:35 +0000 (UTC) Received: from [172.30.42.90] (c27-253-115-14.carlnfd2.nsw.optusnet.com.au [27.253.115.14]) by zmx1.isc.org (Postfix) with ESMTPSA id 8C03F16008A for ; Thu, 18 Jan 2018 23:06:35 +0000 (UTC) To: bind9-public@isc.org X-RT-Incoming-Encryption: Not encrypted X-RT-Interface: Email Date: Fri, 19 Jan 2018 10:06:33 +1100 Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD autolearn=disabled version=3.4.1 RT-Message-ID: Content-Length: 1093 We do not need to change the session nonce. A simple sequence number will prevent replay insertion into the stream and we have that in “_ser” which rndc increases on every transaction. The server is already looking for replays and rejects them. bin/rndc/rndc.c: DO("create message", isccc_cc_createmessage(1, NULL, NULL, ++serial, bin/rndc/rndc.c: DO("create message", isccc_cc_createmessage(1, NULL, NULL, ++serial, > On 18 Jan 2018, at 7:49 pm, Francis Dupont via RT wrote: > > On Thu Jan 18 03:54:57 2018, muks wrote: >> Would you be fine with incrementing the nonce on every subsequent query? > > => a nonce must be not predictable so I am afraid it is not fine > (note I said not predictable vs random as it is the wanted property > and to take the nonce content from a random generator is > only the common way to guarantee the property). > > > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46966 -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org