X-Original-To: bind9-public@bugs.isc.org content-type: text/plain; charset="utf-8" Delivered-To: bind9-public@bugs.isc.org X-RT-Original-Encoding: utf-8 Received: from mx.pao1.isc.org (mx.pao1.isc.org [149.20.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx.pao1.isc.org", Issuer "COMODO RSA Organization Validation Secure Server CA" (not verified)) by bugs.isc.org (Postfix) with ESMTPS id EC203D78B0F for ; Thu, 25 Jan 2018 23:35:23 +0000 (UTC) Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 9FCC63AB001 for ; Thu, 25 Jan 2018 23:35:21 +0000 (UTC) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id 6C8C6160079 for ; Thu, 25 Jan 2018 23:35:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 57C33160077 for ; Thu, 25 Jan 2018 23:35:21 +0000 (UTC) Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id l6rVJ9fQ-K_4 for ; Thu, 25 Jan 2018 23:35:21 +0000 (UTC) Received: from [10.3.201.124] (unknown [120.17.133.98]) by zmx1.isc.org (Postfix) with ESMTPSA id 0E941160075 for ; Thu, 25 Jan 2018 23:35:21 +0000 (UTC) MIME-Version: 1.0 (1.0) X-Mailer: iPhone Mail (15C202) References: Content-Transfer-Encoding: quoted-printable X-RT-Interface: Email From marka@isc.org Thu Jan 25 23:35:24 2018 X-RT-Incoming-Encryption: Not encrypted To: bind9-public@isc.org From: "Mark Andrews" Subject: Re: [ISC-Bugs #47061] unittest.sh fails to run on openBSD Date: Fri, 26 Jan 2018 10:35:17 +1100 In-Reply-To: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD autolearn=disabled version=3.4.1 Return-Path: Message-ID: <79DC37C3-8638-4747-9D62-B4B26F8B514F@isc.org> RT-Message-ID: Content-Length: 779 Command isn’t portable. type atf-run && ATF-RUN=atf-run with error redirect should work. -- Mark Andrews > On 26 Jan 2018, at 08:27, Curtis Blackburn via RT wrote: > > diff --git a/unit/unittest.sh.in b/unit/unittest.sh.in > old mode 100644 > new mode 100755 > index de304c641d..2ddbdb7703 > --- a/unit/unittest.sh.in > +++ b/unit/unittest.sh.in > @@ -2,8 +2,8 @@ > > PATH="@ATFBIN@:${PATH}" > export PATH > -ATFRUN=`type atf-run 2>/dev/null | awk '{print $3}'` > -KYUA=`type kyua 2>/dev/null | awk '{print $3}'` > +ATFRUN=`command -v atf-run 2>/dev/null` > +KYUA=`command -v kyua 2>/dev/null` > > status=0 > if [ -n "@UNITTESTS@" -a -x "$ATFRUN" -a -f Atffile ] > > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=47061