Content-Disposition: inline
MIME-Version: 1.0
X-Mailer: MIME-tools 5.508 (Entity 5.508)
References: <RT-Ticket-47061@isc.org>
 <rt-4.4.1-50502-1516913576-1135.47061-4-0@isc.org>
 <rt-4.4.1-50823-1516915654-1894.47061-4-0@isc.org>
 <79DC37C3-8638-4747-9D62-B4B26F8B514F@isc.org>
 <rt-4.4.1-54528-1516923324-618.47061-0-0@isc.org>
 <rt-4.4.1-67624-1517103205-149.47061-0-0@isc.org>
X-RT-Original-Encoding: utf-8
Message-ID: <rt-4.4.1-67624-1517190476-504.47061-0-0@isc.org>
In-Reply-To: <rt-4.4.1-67624-1517103205-149.47061-0-0@isc.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: binary
X-RT-Interface: Web
RT-Send-CC:
Content-Length: 695

On Sat Jan 27 15:33:26 2018, ckb wrote:
> type isnt portable, and fails to produce the output needed on openbsd.
> command -v runs on every single system in the lab (and the ones I have
> at home).
> 
> On Thu Jan 25 15:35:24 2018, marka wrote:
> > Command isn’t portable.
> >
> >
> > type atf-run && ATF-RUN=atf-run
> >
> > with error redirect should work.
> >

type (posix issue 2) predates command (posix issue 4).
We just have to test for the existence of the commands (exit status).  We don't have
to extract the path (which is where the issue is).

The above said "if atf-run exists then set ATFRUN to atf-run" (corrected variable name).
We could also only do this if ATFRUN was not set.