Message-ID: <LO2P123MB22721CFF775E612B4FD7C7AEEE2D0@LO2P123MB2272.GBRP123.PROD.OUTLOOK.COM>
Content-Language: en-US
Subject: RE: [ISC-Bugs #49169] AutoReply: DHCP 4.4.1 - Dynamic DNS updates are done via TCP instead of UDP
X-MS-Exchange-Crosstenant-Fromentityheader: Hosted
X-Original-To: dhcp-confidential@bugs.isc.org
In-Reply-To: <rt-4.4.1-32001-1554237244-1252.49169-19-0@isc.org>
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(366004)(396003)(376002)(39860400002)(136003)(346002)(13464003)(199004)(189003)(55016002)(14444005)(33656002)(446003)(6436002)(11346002)(76176011)(2351001)(53546011)(6506007)(2420400007)(2906002)(15974865002)(229853002)(7696005)(15650500001)(486006)(478600001)(5640700003)(25786009)(186003)(102836004)(6916009)(5660300002)(68736007)(26005)(66066001)(106356001)(53936002)(6246003)(99286004)(476003)(8676002)(105586002)(52536014)(81156014)(81166006)(8936002)(7110500001)(966005)(3846002)(316002)(6116002)(305945005)(6306002)(256004)(14454004)(86362001)(2501003)(9686003)(7736002)(71190400001)(71200400001)(74316002)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:LO2P123MB2016;H:LO2P123MB2272.GBRP123.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
X-Originatororg: bt.com
References: <RT-Ticket-49169@isc.org> <cb7a6bff2a379a5408c1a55702c10b95@www.isc.org> <rt-4.4.1-32001-1554237244-1252.49169-19-0@isc.org>
From: greg.rabil@bt.com
content-type: text/plain; charset="utf-8"
Thread-Topic: [ISC-Bugs #49169] AutoReply: DHCP 4.4.1 - Dynamic DNS updates are done via TCP instead of UDP
Return-Path: <greg.rabil@bt.com>
Accept-Language: en-US
X-MS-Office365-Filtering-Correlation-ID: a8d6f473-1070-4cb9-b5ed-08d6bcf1f331
X-MS-Publictraffictype: Email
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020);SRVR:LO2P123MB2016;
X-MS-Exchange-Crosstenant-Network-Message-ID: a8d6f473-1070-4cb9-b5ed-08d6bcf1f331
X-MS-Exchange-Crosstenant-Mailboxtype: HOSTED
To: dhcp-confidential@isc.org
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS autolearn=disabled version=3.4.1
Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=greg.rabil@bt.com; 
X-MS-Exchange-Purlcount: 8
Thread-Index: AQHU6ZN/07ad5jfok0KSEMYTajklQKYz4joQ
X-Microsoft-Antispam-Message-Info: kypT+x7t3lS/KK2oWCvn1PyRuWhjNi+VzGIZmIGODysebE3OoGKYj363/8jrrHmhNr2csDs8Kl1nm0AaNtmSUOcYRefD4NlItT6eSHqCMdYYYy6jNJWzT5jE+7dSzuO9hbkM71hr8YmHo/L6kCtIuldyJ6cPHJnoV4rb/uYx3Yr3b+EBLiU6PfjemuaKYKArgfzoa6vxwZZQ1BnMby3qR66P+5YckwEiJrMNv/MxtDSMPnC/FLE0gIiJhO4C1N38fAJ1VjsQUV9qP9N0nRnTR7Hcv46mGvmQXqcJOTG/qUKn0T9h5iE8q7qiBt4MtCS55oyg+pvLg/QA16qPt1heakzo/xzFDQ/f6xDZ0f40VDxR5elGYJQ4c/egUtzE9Yzg0QHaBSkhBa4HVVQPk7xudAh65c7F9g3YdpqD4IO4xRE=
Content-Transfer-Encoding: base64
Received-SPF: None (protection.outlook.com: bt.com does not designate permitted sender hosts)
X-RT-Original-Encoding: utf-8
MIME-Version: 1.0
From greg.rabil@bt.com  Tue Apr  9 13:47:55 2019
X-Microsoft-Antispam-PRVS: <LO2P123MB2016B57C31FE811207340826EE2D0@LO2P123MB2016.GBRP123.PROD.OUTLOOK.COM>
X-MS-Exchange-Senderadcheck: 1
X-MS-Tnef-Correlator: 
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mx.pao1.isc.org
Date: Tue, 9 Apr 2019 13:47:46 +0000
X-MS-Exchange-Crosstenant-ID: a7f35688-9c00-4d5e-ba41-29f146377ab0
X-Forefront-PRVS: 000227DA0C
Delivered-To: dhcp-confidential@bugs.isc.org
X-MS-Has-Attach: 
X-MS-Exchange-Crosstenant-Originalarrivaltime: 09 Apr 2019 13:47:47.0934 (UTC)
X-MS-Exchange-Transport-Crosstenantheadersstamped: LO2P123MB2016
X-Originating-Ip: [98.114.18.26]
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bt.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eh24RSteQHf4AlzTyofpV7wO8d+pAhDws9r/5iA5iLY=; b=6Jg/Mmx4IiR0n/nTq+MOLkLplH0B8dLBssK518X/fZDzgqZ1MEFl2cfdZdMpLLSjSdj/LfVvRum4rdFtGwQb89n1d6U2/jIbwqWwUHGtbTsk1eU8DkCeoA7A2R2vj2gF/7DrSTmU3VAZPUv3nxSBeHEPhaFBEymnyxkiufCkWhw=
RT-Message-ID: <rt-4.4.1-96447-1554817680-534.49169-0-0@isc.org>
Content-Length: 4976

Hello,
Do you have any comment about this bug report?

Thanks,
Greg Rabil

-----Original Message-----
From: DHCP Bugs via RT [mailto:dhcp-confidential@isc.org] 
Sent: Tuesday, April 2, 2019 4:34 PM
To: Rabil,AG,A Gregory,JTK2 R <greg.rabil@bt.com>
Subject: [ISC-Bugs #49169] AutoReply: DHCP 4.4.1 - Dynamic DNS updates are done via TCP instead of UDP

Greetings,

This message was automatically generated to acknowledge receipt of your recent email  "DHCP 4.4.1 - Dynamic DNS updates are done via TCP instead of UDP", and to let you know that we have opened a ticket for your request (a summary of which appears below.)

We do not need a further response from you at this time, but if you do respond, please include in the Subject of your reply the ID
   '[ISC-Bugs #49169]'
so that we can match up your reply with the ticket in our system.


What Happens Next
=================

Bug reports submitted to us in this manner are handled based on perceived severity in relation to other bugs.  We handle reports as time permits so there is no guaranteed response time for these reports.

If you feel the issue you are reporting is a security issue, please see http://www.isc.org/security/reporting-issues for details on how to report it, including the PGP key you may use.

If it is of a non-security yet still urgent matter, you may reply to this message to add further information.


Public Visibility of Bugs
=========================

Most bind and dhcp bug reports submitted since July 7, 2017 are visible to the public at https://bugs.isc.org <https://bugs.isc.org/> after review by the developers.

If you want this report to be withheld from public view, please reply to this message with your request.

All reports submitted to
  bind9-confidential@isc.org <mailto:bind9-confidential@isc.org> and
  dhcp-confidential@isc.org <mailto:dhcp-confidential@isc.org>
are withheld from public view.

Other Support Options
=====================

If your organization requires more immediate attention, ISC offers paid support options.  Please see http://www.isc.org/services/support
for more information.

If paid support is not an option, please consider making a donation to ISC.  We don't require a donation -- we will work on your report just as quickly whether or not you can donate -- but we always need and welcome community support.  See http://www.isc.org/donate/


Run a Supported Version
=======================

If you are not running a supported version of our software, please upgrade.  Bug reports against unsupported versions of BIND are discouraged, as your issue may have already been addressed.

You can find the latest versions of our software here:

    https://www.isc.org/downloads/


For configuration help...
=========================

Questions regarding configuration or setup are addressed on mailing lists - to subscribe, visit:

     https://lists.isc.org/mailman/listinfo/bind-users
 or  https://lists.isc.org/mailman/listinfo/dhcp-users


Thank you,
  dhcp-confidential@isc.org

---------------------------------------------------------------------

Bug Report from www.isc.org:

Name: Greg Rabil
Email: greg.rabil@bt.com
Software Version: DHCP 4.4.1
OS: Linux
Subject:Dynamic DNS updates are done via TCP instead of UDP


Bug Detail
===========
In DHCP 4.3, all dynamic DNS updates are performed using UDP.  In DHCP 4.4, that behavior has changed to use TCP.  As far as I can tell, this change was not intentional, and instead is a bug caused by changes in the BIND library.

In both DHCP 4.3 and 4.4, the common/dns.c source file contains a macro that maps ddns_update to dns_client_startupdate.  When the ddns_modify_fwd function calls ddns_update (dns_client_startupdate), it passes DNS_CLIENTRESOPT_ALLOWRUN as the eight argument.  The bind/include/dns/client.h file defines DNS_CLIENTRESOPT_ALLOWRUN as 0x02.

The problem stems from the change in the implementation of the dns_client_startupdate function between the bind-9.9.11 package in DHCP 4.3 and the bind-9.11.2-p1 package in DHCP 4.4.  Specifically, in bind-9.9.11, the implementation of dns_client_startupdate in lib/dns/client.c references the eight parameter (options) only in this line:

        UNUSED(options);

However, in bind-9.11-2-p1, the implementation includes the line above, as well as this line:

        want_tcp = ISC_TF((options & DNS_CLIENTUPDOPT_TCP) != 0);

Note that lib/dns/include/dns/client.h defines DNS_CLIENTUPDOPT_TCP as 0x02, which then sets the 'want_tcp' boolean to true.

Since the caller (client.c in DHCP source code) is intending to set DNS_CLIENTRESOPT_ALLOWRUN flag via the options parameter, but not the DNS_CLIENTUPDOPT_TCP flag, this is the source of the problem, and a change in behavior with respect to the DDNS updates using UDP in DHCP 4.3 but TCP in DHCP 4.4.

---
This email was received through isc.org Bug Submission Form