MIME-Version: 1.0
In-Reply-To: <rt-3.8.6-60457-1279663826-1046.19867-5-0@isc.org>
References: <RT-Ticket-19867@isc.org> <alpine.LFD.2.00.0906261359400.18197@mitre.honolulu.burdell.org> <rt-3.8.6-60457-1279663826-1046.19867-5-0@isc.org>
Message-ID: <alpine.LFD.2.00.1007210740540.3927@localhost>
Content-Type: TEXT/PLAIN; charset="utf-8"; format="flowed"
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
Subject: Re: [ISC-Bugs #19867] common/dispatch.c: add_timeout() when parameter NULL 
Date: Wed, 21 Jul 2010 07:43:39 -1000 (HST)
To: Shawn Routhier via RT <dhcp-bugs@isc.org>
From: David Cantrell <dcantrell@redhat.com>
RT-Message-ID: <rt-3.8.6-60436-1279734530-1570.19867-0-0@isc.org>
Content-Length: 1010

On Tue, 20 Jul 2010, Shawn Routhier via RT wrote:

> I've (finally) looked at this ticket and reviewed the code and don't
> see a way to get a NULL in the client calls to add_timeout().
>
> Before deciding what to do with the ticket I wanted to check and see
> if you had any more information, especially if this was seen in 4.1.1
> as well as 4.1.0. I realize the ticket is older and won't be surprised if
> you don't have any additional information.

I sent in that patch on 29-Jun-2009, if I remember correctly.  I can't really
remember the specifics of the situation, but I do remember tracking down the
problem and coming up with this patch.  It's really more patching the symptom
rather than the problem, but I was time constrained.

At any rate, if I had to guess now, I'd say it was alignment issues leading to
'when' set to NULL on 32-bit systems.  This may also be a very specific case
because it was back during Fedora 11.

Thanks,

-- 
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI