Report information
The Basics
Id:
40591
Status:
resolved
Estimated:
8 hours (480 minutes)
Worked:
2.67 hours (160 minutes)
Users:
tmark: 2.67 hours (160 minutes)
Left:
8 hours (480 minutes)
Priority:
Low/Low
Queue:
dhcp-public
People
BugTracker
Version Fixed:
4.3.4 4.1-ESV-R13
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
4.3.4
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
DHCP Server
Area:
bug
Attachments
0001-VLAN-ID-is-only-bottom-12-bits-of-TCI.patch
Dates
Created:Thu, 03 Sep 2015 12:56:37 -0400
Updated:Fri, 07 Jul 2017 19:41:39 -0400
Closed:Thu, 24 Sep 2015 07:09:15 -0400

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Thu, 03 Sep 2015 12:56:37 -0400 Jiri Popelka <jpopelka@redhat.com> - Ticket created
Subject: lpf wrongly checks for VLAN ID
Date: Thu, 3 Sep 2015 18:56:31 +0200
To: dhcp-bugs@isc.org
From: "Jiri Popelka" <jpopelka@redhat.com>

Hello, I've had a bug report [1] from a guy [2] from CISCO, that a recently added check [3] in lpf breaks dhclient for him. He clearly describes the culprit in comment #7: "The check is checking the whole TCI value in the packet rather than just the VLAN ID portion. It should be checking only the bottom 12-bits of the TCI." He seems to be right, see for example [4] or [5]. I've attached the patch he's testing now. -- Jiri [1] https://bugzilla.redhat.com/show_bug.cgi?id=1259552 [2] Keith Mitchell: kamitch@cisco.com [3] https://source.isc.org/cgi-bin/gitweb.cgi?p=dhcp.git;a=commitdiff;h=29170f9da9826bd7191f4ad644e61b76c49f6cc6 [4] http://www.microhowto.info/tutorials/802.1q.html#idp6080 [5] https://en.wikipedia.org/wiki/IEEE_802.1Q#Frame_format
0001-VLAN-ID-is-only-bottom-12-bits-of-TCI.patch

Message body is not shown because sender requested not to inline it.

Wed, 09 Sep 2015 01:06:54 -0400 Shawn Routhier <sar@isc.org> - Priority P2 Normal added
Wed, 09 Sep 2015 01:06:54 -0400 Shawn Routhier <sar@isc.org> - Versions Planned 4.3.4 added
Wed, 09 Sep 2015 01:06:55 -0400 Shawn Routhier <sar@isc.org> - Severity S2 Normal added
Wed, 09 Sep 2015 01:06:55 -0400 Shawn Routhier <sar@isc.org> - FinalPriority changed from 'Medium' to 'Low'
Wed, 09 Sep 2015 01:06:56 -0400 Shawn Routhier <sar@isc.org> - Priority changed from 'Medium' to 'Low'
Wed, 09 Sep 2015 01:06:56 -0400 Shawn Routhier <sar@isc.org> - TimeEstimated changed from (no value) to '480'
Wed, 09 Sep 2015 01:06:57 -0400 Shawn Routhier <sar@isc.org> - TimeLeft changed from (no value) to '480'
Wed, 09 Sep 2015 01:06:57 -0400 Shawn Routhier <sar@isc.org> - Status changed from 'new' to 'open'
Tue, 22 Sep 2015 09:35:05 -0400 Thomas Markwalder <tmark@isc.org> - Taken
Tue, 22 Sep 2015 13:48:19 -0400 Thomas Markwalder <tmark@isc.org> - Worked 2 hours (120 minutes) 120 minutes
Tue, 22 Sep 2015 13:48:20 -0400 Thomas Markwalder <tmark@isc.org> - Queue changed from #8 to #9
Tue, 22 Sep 2015 13:48:20 -0400 Thomas Markwalder <tmark@isc.org> - Untaken
Tue, 22 Sep 2015 14:51:25 -0400 Shawn Routhier <sar@isc.org> - Given to Thomas Markwalder <tmark@isc.org>
Wed, 23 Sep 2015 10:00:49 -0400 Thomas Markwalder <tmark@isc.org> - Version Fixed 4.3.4 4.1-ESV-R13 added
Wed, 23 Sep 2015 10:00:50 -0400 Thomas Markwalder <tmark@isc.org> - Worked 40 minutes 40 minutes
Wed, 23 Sep 2015 10:00:51 -0400 Thomas Markwalder <tmark@isc.org> - Dependency by #40191: added
Wed, 23 Sep 2015 10:00:51 -0400 Thomas Markwalder <tmark@isc.org> - Dependency by #40192: added
  Wed, 23 Sep 2015 10:05:05 -0400 Thomas Markwalder <tmark@isc.org> - Correspondence added

Hello Jiri: We have implemented the patch you supplied to correct this issue. It will be in included in 4.3.4 and 4.1-ESV-R13. As usual we've given you due credit and the release notes and thank you for continued involvement and contributions. Keep 'em coming! Sincerely, Thomas Markwalder ISC Software Engineering
Wed, 23 Sep 2015 10:05:24 -0400 Thomas Markwalder <tmark@isc.org> - Status changed from 'open' to 'resolved'
  Wed, 23 Sep 2015 11:37:00 -0400 Jiri Popelka <jpopelka@redhat.com> - Correspondence added
Subject: Re: [ISC-Bugs #40591] lpf wrongly checks for VLAN ID
Date: Wed, 23 Sep 2015 17:36:55 +0200
To: dhcp-review@isc.org
From: "Jiri Popelka" <jpopelka@redhat.com>

Thanks. There's a typo in RELNOTES: "The linux packet fitler code ..." s/fitler/filter/ -- Jiri
Wed, 23 Sep 2015 11:37:01 -0400 The RT System itself - Status changed from 'resolved' to 'open'
  Thu, 24 Sep 2015 07:08:57 -0400 Thomas Markwalder <tmark@isc.org> - Correspondence added

On Wed Sep 23 15:37:00 2015, jpopelka@redhat.com wrote: > Thanks. > > There's a typo in RELNOTES: > > "The linux packet fitler code ..." > > s/fitler/filter/ > > -- > Jiri > Oops, got it. Thanks.
Thu, 24 Sep 2015 07:09:15 -0400 Thomas Markwalder <tmark@isc.org> - Status changed from 'open' to 'resolved'
Fri, 12 Feb 2016 06:09:05 -0500 Stephen Morris <stephen@isc.org> - Area bug added
Fri, 12 Feb 2016 06:09:05 -0500 Stephen Morris <stephen@isc.org> - Component DHCP Server added
Wed, 21 Jun 2017 15:40:37 -0400 Brian Conry <bconry@isc.org> - Queue changed from #9 to #8
Fri, 07 Jul 2017 19:41:39 -0400 Vicky Risk <vicky@isc.org> - Queue changed from #8 to dhcp-public