Report information
The Basics
Id:
45980
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
Cc:
AdminCc:

BugTracker
Version Fixed:
9.9.11(sub), 9.10.6, 9.10.6(sub), 9.11.1, 9.12.0
Version Found:
master
Versions Affected:
9.10.*, 9.9.*-S*, 9.11.*
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
bug

Dates
Created:Mon, 11 Sep 2017 15:57:42 -0400
Updated:Tue, 12 Sep 2017 07:07:31 -0400
Closed:Tue, 12 Sep 2017 07:07:31 -0400



This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

To: bind9-public@isc.org
Subject: JSON stats TreeMemMax emitted as HeapMemMax
Date: Mon, 11 Sep 2017 19:57:42 +0000
From: bconry@isc.org
in lib/dns/cache.c:dns_cache_renderjson: obj = json_object_new_int64(isc_mem_maxinuse(cache->mctx)); CHECKMEM(obj); json_object_object_add(cstats, "HeapMemMax", obj); should be: obj = json_object_new_int64(isc_mem_maxinuse(cache->mctx)); CHECKMEM(obj); json_object_object_add(cstats, "TreeMemMax", obj); Note that there is a proper HeapMemMax emitted later: obj = json_object_new_int64(isc_mem_maxinuse(cache->hmctx)); CHECKMEM(obj); json_object_object_add(cstats, "HeapMemMax", obj);
a proper diff of the issue: diff --git a/lib/dns/cache.c b/lib/dns/cache.c index 10e2331..4f234e2 100644 --- a/lib/dns/cache.c +++ b/lib/dns/cache.c @@ -1581,7 +1581,7 @@ dns_cache_renderjson(dns_cache_t *cache, json_object *cstats) { obj = json_object_new_int64(isc_mem_maxinuse(cache->mctx)); CHECKMEM(obj); - json_object_object_add(cstats, "HeapMemMax", obj); + json_object_object_add(cstats, "TreeMemMax", obj); obj = json_object_new_int64(isc_mem_total(cache->hmctx)); CHECKMEM(obj);
ready for review
4715. [bug] TreeMemMax was mis-identified as a second HeapMemMax in the Json cache statistics. [RT #45980]