Report information
The Basics
Id:
46012
Status:
resolved
Priority:
Medium/Medium
Queue:

People
Owner:
Nobody in particular
Requestors:
scan-admin@coverity.com(no email address set)
Cc:
AdminCc:

BugTracker
Version Fixed:
9.9.12,9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
bug

Dates
Created:Fri, 15 Sep 2017 12:00:52 -0400
Updated:Tue, 26 Sep 2017 23:49:42 -0400
Closed:Tue, 26 Sep 2017 23:49:42 -0400



This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

Subject: New Defects reported by Coverity Scan for BIND
To: bind9-bugs@isc.org
From: scan-admin@coverity.com
Date: Fri, 15 Sep 2017 16:00:34 +0000 (UTC)
Hi, Please find the latest report on new defect(s) introduced to BIND found with Coverity Scan. 2 new defect(s) introduced to BIND found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1417752: Control flow issues (DEADCODE) /bin/named/server.c: 2345 in configure_rpz() ________________________________________________________________________________________________________ *** CID 1417752: Control flow issues (DEADCODE) /bin/named/server.c: 2345 in configure_rpz() 2339 2340 if (dnsrps_enabled) { 2341 /* 2342 * Generate the DNS Response Policy Service 2343 * configuration string. 2344 */ >>> CID 1417752: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "result = conf_dnsrps(view, ...". 2345 result = conf_dnsrps(view, maps, 2346 nsip_enabled, nsdname_enabled, 2347 &nsip_on, &nsdname_on, 2348 &rps_cstr, &rps_cstr_size, 2349 rpz_obj, zone_element); 2350 if (result != ISC_R_SUCCESS) ** CID 1417751: Control flow issues (DEADCODE) /lib/irs/getnameinfo.c: 323 in irs_getnameinfo() ________________________________________________________________________________________________________ *** CID 1417751: Control flow issues (DEADCODE) /lib/irs/getnameinfo.c: 323 in irs_getnameinfo() 317 case DNS_R_COVERINGNSEC: 318 case DNS_R_NOTAUTHORITATIVE: 319 case DNS_R_NOVALIDKEY: 320 case DNS_R_NOVALIDDS: 321 case DNS_R_NOVALIDSIG: 322 ERR(EAI_INSECUREDATA); >>> CID 1417751: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "break;". 323 break; 324 default: 325 ERR(EAI_FAIL); 326 } 327 328 /* Parse the answer for the hostname */ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRatftY8JjD0XUVeK0eDwSEPh4vRqywf0w3swJ8N5sF82Q-3D-3D_QjBaZtEJDFdtBJj3YWWx4OwxXn6h7X1bCFA-2BmidshrjiPDbQNKu4jHz2Sgaw3OuxzTZLZTCdPl38sDK7KGQJqEWiCrSO0dxKhMLEikjPV7M3KhQInKDdN8TjBj-2FdCfdThX0gYND-2BfTU0rEPr9s-2B5iphyeNHNG-2FKNPuSD7kGAUqUhH2rzUojyPrL61wQismIjuBi20G8OmmL5wGBJyeyfgYEMSI-2FHhuhA97MXCmjzgBY-3D To manage Coverity Scan email notifications for "bind9-bugs@isc.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4rIy41Xs74BznZj4k3EIh0OhIeqrl4tMKvZau-2B5LUEdCBSWjNYx5kf-2B92zKd1nnWiMMfay-2Fg7DuBn2-2BCqidUp9Y39BJMi1Fd-2FeSXcvFgX1I4-3D_QjBaZtEJDFdtBJj3YWWx4OwxXn6h7X1bCFA-2BmidshrjiPDbQNKu4jHz2Sgaw3Ouxyj0qNF-2FpR6A56cFowT26l6XZE5yuaIwE7e4cer-2BMLKTnF-2FrD3ySSimODcPeq0dd9OCBL9GeXgoSHfT0NfpaCULJ98nTT-2FSF-2FRZUJYMJ8dj07vKwuxvKTxXIQsNKwFbwlmva7ytR5KrnF4mIeWKUGk96EuvRKGU2hApcFq6CMTLc-3D
I prepared an alternative approach in rt46012_michal. It slightly refactors the code in configure_rpz() so that it reads a bit more nicely by avoiding a double #ifdef and a triple dnsrps_enabled check while retaining identical code flow. As a bonus, it surrounds conf_dnsrps* with an #ifdef to prevent a compiler warning when building without DNSRPS support. If you like it, feel free to use it. Otherwise, your fix is good to go as well.
4737. [cleanup] Address Coverity warnings. [RT #46012]