Report information
The Basics
Id:
46084
Status:
resolved
Estimated:
16 hours (960 minutes)
Priority:
Low/Low
Queue:
dhcp-public
People
BugTracker
Version Fixed:
(no value)
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
4.4.0
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
(no value)
Attachments
0001-Add-local-address6-parameter-identical-to-local-addr.patch smime.p7s
Dates
Created:Sat, 23 Sep 2017 18:42:29 -0400
Updated:Wed, 20 Dec 2017 03:55:37 -0500
Closed:Wed, 20 Dec 2017 03:55:37 -0500

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Sat, 23 Sep 2017 18:42:29 -0400 Wim Vandersmissen <wim.vandersmissen@kuleuven.be> - Ticket created
Date: Sat, 23 Sep 2017 22:41:27 +0000
From: "Wim Vandersmissen" <wim.vandersmissen@kuleuven.be>
Subject: [PATCH] Add local-address6 support
To: "dhcp-suggest@isc.org" <dhcp-suggest@isc.org>


This patch adds support for local-address6 so that an ipv6 address can be specified.


Thanks,


Wim

0001-Add-local-address6-parameter-identical-to-local-addr.patch

Message body not shown because it is not plain text.

  Mon, 25 Sep 2017 07:43:26 -0400 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Sat Sep 23 22:42:29 2017, wim.vandersmissen@kuleuven.be wrote: > This patch adds support for local-address6 so that an ipv6 address can > be specified. => either I missed something in the master branch or the corresponding branch was not merged for an unknown reason but IMHO it is clear the local-address6 support is required (and I remember to have implemented it). Anyway it should be in the next release and perhaps even back-ported.
Mon, 25 Sep 2017 07:43:27 -0400 The RT System itself - Status changed from 'new' to 'open'
Mon, 25 Sep 2017 07:52:20 -0400 Thomas Markwalder <tmark@isc.org> - Given to Francis Dupont <Francis_Dupont@isc.org>
Mon, 25 Sep 2017 07:52:21 -0400 Thomas Markwalder <tmark@isc.org> - Priority P2 Normal added
Mon, 25 Sep 2017 07:52:21 -0400 Thomas Markwalder <tmark@isc.org> - Versions Planned 4.4.0 added
Mon, 25 Sep 2017 07:52:21 -0400 Thomas Markwalder <tmark@isc.org> - Severity S2 Normal added
Mon, 25 Sep 2017 07:52:39 -0400 Thomas Markwalder <tmark@isc.org> - FinalPriority changed from 'Low' to 'Low'
Mon, 25 Sep 2017 07:52:39 -0400 Thomas Markwalder <tmark@isc.org> - Priority changed from 'Low' to 'Low'
  Mon, 25 Sep 2017 08:17:52 -0400 Wim Vandersmissen <wim.vandersmissen@kuleuven.be> - Correspondence added
Subject: RE: [ISC-Bugs #46084] [PATCH] Add local-address6 support
Date: Mon, 25 Sep 2017 12:17:14 +0000
To: "dhcp-public@isc.org" <dhcp-public@isc.org>
From: "Wim Vandersmissen" <wim.vandersmissen@kuleuven.be>

Great, thanks! Wim -----Original Message----- From: Francis Dupont via RT [mailto:dhcp-public@isc.org] Sent: maandag 25 september 2017 13:43 To: Wim Vandersmissen <wim.vandersmissen@kuleuven.be> Subject: [ISC-Bugs #46084] [PATCH] Add local-address6 support On Sat Sep 23 22:42:29 2017, wim.vandersmissen@kuleuven.be wrote: > This patch adds support for local-address6 so that an ipv6 address can > be specified. => either I missed something in the master branch or the corresponding branch was not merged for an unknown reason but IMHO it is clear the local-address6 support is required (and I remember to have implemented it). Anyway it should be in the next release and perhaps even back-ported.
smime.p7s

Message body not shown because it is not plain text.

Mon, 02 Oct 2017 11:32:25 -0400 Thomas Markwalder <tmark@isc.org> - TimeEstimated changed from (no value) to '960'
  Tue, 19 Dec 2017 04:26:16 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

I have 3 different codes using the local_address6 value at a different place: - old "option-to" patch where if_register6() uses it in the if_register_socket() for global_v6_socket - new "parameter-identical" where send_packet6() uses it for the pktinfo->ipi6_addr - DHCPv4-over-IPv6 (rt28195b) branch where if_register_socket() binds to it Only the last one provides a text for dhcpd.conf.5 which (incorrectly) explains the effect of the new server option. Have to think about what is needed (seems the second option): implement and fix it...
  Tue, 19 Dec 2017 06:40:21 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Tue Dec 19 09:26:16 2017, fdupont wrote: > I have 3 different codes using the local_address6 > value at a different place: > > - old "option-to" patch where if_register6() uses > it in the if_register_socket() for global_v6_socket > > - new "parameter-identical" where send_packet6() > uses it for the pktinfo->ipi6_addr > > - DHCPv4-over-IPv6 (rt28195b) branch where > if_register_socket() binds to it > > Only the last one provides a text for dhcpd.conf.5 > which (incorrectly) explains the effect of the new > server option. > > Have to think about what is needed (seems the > second option): implement and fix it... => decided: need both so I'll add a second server option to bind the local IPv6 address.
  Tue, 19 Dec 2017 11:07:06 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

Done. Ready for review.
Tue, 19 Dec 2017 11:07:07 -0500 Francis Dupont <Francis_Dupont@isc.org> - Status changed from 'open' to 'review'
Tue, 19 Dec 2017 11:07:07 -0500 Francis Dupont <Francis_Dupont@isc.org> - Untaken
Tue, 19 Dec 2017 11:17:06 -0500 Thomas Markwalder <tmark@isc.org> - Taken
Tue, 19 Dec 2017 12:48:14 -0500 Francis Dupont <Francis_Dupont@isc.org> - Dependency by #44535: Patch: DHCP relay port feature code for review (from Cisco - Support ticket #11062) added
Tue, 19 Dec 2017 13:17:40 -0500 Thomas Markwalder <tmark@isc.org> - Given to Francis Dupont <Francis_Dupont@isc.org>
  Tue, 19 Dec 2017 13:39:19 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Tue Dec 19 18:17:39 2017, tmark wrote: > On Tue Dec 19 16:07:06 2017, fdupont wrote: > > Done. Ready for review. > > I made some minor wording changes to the man page, so please pull. > > The code looks ok. I tested it using two Centos VMs. local-address > by itself worked fine, the src value was indeed the address I > specified, 3002::30. This is the address on the interface the server > was listening upon. => note no check is done for the address so if you put a junk value you likely get an error. > However, when I enabled bind-local-address, the > client stopped get server replies, nor did they show under pcap for > the server interface. > > It's probably something in my environment, how did you test this? => I verified the socket was correctly bound by lsof. Note it is likely not compatible with multicast so with 2 VMs it becomes very system dependent so I am not surprised it fails with CentOS. Did the server get solicits/requests? I am afraid this kind of setup requires a relay: same than for local-address...
Tue, 19 Dec 2017 13:40:00 -0500 Francis Dupont <Francis_Dupont@isc.org> - Given to Thomas Markwalder <tmark@isc.org>
Tue, 19 Dec 2017 13:48:32 -0500 Thomas Markwalder <tmark@isc.org> - Given to Francis Dupont <Francis_Dupont@isc.org>
Tue, 19 Dec 2017 14:53:50 -0500 Francis Dupont <Francis_Dupont@isc.org> - Given to Thomas Markwalder <tmark@isc.org>
Tue, 19 Dec 2017 14:54:22 -0500 Francis Dupont <Francis_Dupont@isc.org> - Stolen from Thomas Markwalder <tmark@isc.org>
  Tue, 19 Dec 2017 14:56:20 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Tue Dec 19 18:48:31 2017, tmark wrote: => BTW the similar feature in Kea is known to require a relay. > Ok, then go ahead and merge this in. => merging. I'll close when the RELNOTES will be approved.
Tue, 19 Dec 2017 15:03:58 -0500 Francis Dupont <Francis_Dupont@isc.org> - Given to Thomas Markwalder <tmark@isc.org>
Tue, 19 Dec 2017 15:36:00 -0500 Thomas Markwalder <tmark@isc.org> - Given to Francis Dupont <Francis_Dupont@isc.org>
  Tue, 19 Dec 2017 15:44:10 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Tue Dec 19 20:35:59 2017, tmark wrote: > On Tue Dec 19 19:56:20 2017, fdupont wrote: > > On Tue Dec 19 18:48:31 2017, tmark wrote: > > => BTW the similar feature in Kea is known to > > require a relay. > > > > > Ok, then go ahead and merge this in. > > > > => merging. I'll close when the RELNOTES > > will be approved. > > Did you forget to push? I don't see any RELNOTES for it. => I merged it on master. I expect the RELNOTES entry I added to be correct but I'll close the ticket only after its review (please fix it directly if something is wrong in the wording).
Tue, 19 Dec 2017 15:44:25 -0500 Francis Dupont <Francis_Dupont@isc.org> - Given to Thomas Markwalder <tmark@isc.org>
Wed, 20 Dec 2017 03:55:04 -0500 Francis Dupont <Francis_Dupont@isc.org> - Stolen from Thomas Markwalder <tmark@isc.org>
Wed, 20 Dec 2017 03:55:37 -0500 Francis Dupont <Francis_Dupont@isc.org> - Status changed from 'review' to 'resolved'