Report information
The Basics
Id:
46340
Status:
resolved
Priority:
Medium/Medium
Queue:
bind9-public
People
Owner:
Nobody in particular
Requestors:
Evan Hunt <Evan_Hunt@isc.org>
Cc:
AdminCc:
BugTracker
Version Fixed:
9.12.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
9.13
Priority:
P3 Low
Severity:
S3 Low
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
feature
Dates
Created:Thu, 19 Oct 2017 21:09:15 -0400
Updated:Tue, 28 Nov 2017 11:42:04 -0500
Closed:Tue, 28 Nov 2017 11:42:03 -0500

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Thu, 19 Oct 2017 21:09:17 -0400 Evan Hunt <Evan_Hunt@isc.org> - Ticket created
From: Evan_Hunt@isc.org
Date: Fri, 20 Oct 2017 01:09:14 +0000
To: bind-suggest@isc.org
Subject: get rid of the filter-aaaa compile time option

There's no real reason for this to be a compile time option anymore, or for there to be separate QA builds with and without it.
  Thu, 19 Oct 2017 21:16:49 -0400 Mark Andrews <marka@isc.org> - Correspondence added
Subject: Re: [ISC-Bugs #46340] get rid of the filter-aaaa compile time option
To: bind-suggest@isc.org
From: "Mark Andrews" <marka@isc.org>
Date: Fri, 20 Oct 2017 12:15:25 +1100

In message <rt-4.4.1-74962-1508461758-1855.46340-3-0@isc.org>, "Evan Hunt via R T" writes: > There's no real reason for this to be a compile time option anymore, or for > there to be separate QA builds with and without it. The configure time option was deliberate. Filter AAAA records really shouldn't be done and making it a configure option deliberately adds another road block to the decision to do this. -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org
  Thu, 19 Oct 2017 21:24:57 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

Please review rt46340. We'll need to discuss when it would be okay to commit this. It's a functional change (though not on Windows, where filter-aaaa has been compiled in since always), and we're past feature freeze for 9.12, so normally it would have to wait until 9.13, unless we have a good reason to merge it sooner. In this case, though, the risk is *so* low - almost zero; it's not as if this code hasn't been thoroughly tested - that in my opinion, reducing the QA burden is a good enough reason. 9.13 is a long time to wait.
Thu, 19 Oct 2017 21:24:58 -0400 Evan Hunt <Evan_Hunt@isc.org> - Status changed from 'open' to 'review'
Thu, 19 Oct 2017 21:24:58 -0400 Evan Hunt <Evan_Hunt@isc.org> - Untaken
  Thu, 19 Oct 2017 21:32:10 -0400 Evan Hunt <each@isc.org> - Correspondence added
From: "Evan Hunt" <each@isc.org>
To: "Mark Andrews via RT" <bind-suggest@isc.org>
CC:
Subject: Re: [ISC-Bugs #46340] get rid of the filter-aaaa compile time option
Date: Fri, 20 Oct 2017 01:32:08 +0000

> The configure time option was deliberate. Filter AAAA records > really shouldn't be done and making it a configure option deliberately > adds another road block to the decision to do this. I know it was deliberate, but it's unnecessary now. The reason was largely political and the politics have changed now. And the option is already turned off by default, and it's documented as "not recommended". We should either kill it dead (though I suspect we can't without impacting people) or turn it on so it gets tested without having to run extra robie/jenkins builds. Hopefully after 9.13 it'll be a hook module and not part of stock named anymore anyway.
  Fri, 20 Oct 2017 03:33:53 -0400 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Fri Oct 20 01:24:57 2017, each wrote: > Please review rt46340. > > We'll need to discuss when it would be okay to commit this. It's a > functional > change (though not on Windows, where filter-aaaa has been compiled in > since always) => I disagree about the Windows comment: your wording suggests it is always compiled in when it is a configuration option "on" by default.
Fri, 20 Oct 2017 11:09:40 -0400 Vicky Risk <vicky@isc.org> - Area feature added
Fri, 20 Oct 2017 11:09:40 -0400 Vicky Risk <vicky@isc.org> - Severity S3 Low added
Fri, 20 Oct 2017 11:09:40 -0400 Vicky Risk <vicky@isc.org> - Versions Planned 9.13 added
Fri, 20 Oct 2017 11:09:40 -0400 Vicky Risk <vicky@isc.org> - Priority P3 Low added
Fri, 20 Oct 2017 11:09:58 -0400 Vicky Risk <vicky@isc.org> - Queue changed from #3 to bind9-public
  Fri, 20 Oct 2017 13:10:36 -0400 Evan Hunt <each@isc.org> - Correspondence added
From: "Evan Hunt" <each@isc.org>
To: "Francis Dupont via RT" <bind-suggest@isc.org>
Subject: Re: [ISC-Bugs #46340] get rid of the filter-aaaa compile time option
Date: Fri, 20 Oct 2017 17:10:34 +0000
CC:

> => I disagree about the Windows comment: your wording suggests > it is always compiled in when it is a configuration option "on" by > default. It's available by default to anyone who uses our zips instead of compiling their own (which I suspect is the vast majority of windows users), and it was available by default before you wrote Configure and everything for windows was hardcoded.
  Mon, 23 Oct 2017 16:59:53 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

So do we have consensus that this is a good idea? If so, the code still needs to be reviewed.
Tue, 24 Oct 2017 13:31:54 -0400 Evan Hunt <Evan_Hunt@isc.org> - Taken
Tue, 24 Oct 2017 13:32:13 -0400 Evan Hunt <Evan_Hunt@isc.org> - Untaken
  Wed, 25 Oct 2017 03:01:40 -0400 Mark Andrews <marka@isc.org> - Correspondence added

On Mon Oct 23 10:59:53 2017, each wrote: > So do we have consensus that this is a good idea? > > If so, the code still needs to be reviewed. There were some more cleanups required.
  Wed, 25 Oct 2017 03:02:23 -0400 Mark Andrews <marka@isc.org> - Correspondence added

Looks good to go now if you are happy with them.
Wed, 25 Oct 2017 03:02:24 -0400 Mark Andrews <marka@isc.org> - Given to Evan Hunt <Evan_Hunt@isc.org>
  Wed, 25 Oct 2017 03:36:15 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

4786. [func] The "filter-aaaa-on-v4" and "filter-aaaa-on-v6" options are no longer conditionally compiled. [RT #46340] 9.12.0 Note to QA: any test builds we have that specify this configure option for master can be changed or removed now.
Wed, 25 Oct 2017 03:36:16 -0400 Evan Hunt <Evan_Hunt@isc.org> - Status changed from 'review' to 'qa'
Wed, 25 Oct 2017 03:36:16 -0400 Evan Hunt <Evan_Hunt@isc.org> - Untaken
Wed, 25 Oct 2017 03:36:16 -0400 Evan Hunt <Evan_Hunt@isc.org> - Version Fixed 9.12.0 added
  Tue, 28 Nov 2017 11:42:03 -0500 Stephen Morris <stephen@isc.org> - Correspondence added

QA has reviewed the Jenkins jobs for the master branch. Resolving.
Tue, 28 Nov 2017 11:42:04 -0500 Stephen Morris <stephen@isc.org> - Status changed from 'qa' to 'resolved'