Report information
The Basics
Id:
46407
Status:
resolved
Priority:
Low/Low
Queue:
bind9-public
People
BugTracker
Version Fixed:
9.11.3, 9.12.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P3 Low
Severity:
S3 Low
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
test
Dates
Created:Thu, 26 Oct 2017 05:17:31 -0400
Updated:Sat, 28 Oct 2017 14:29:48 -0400
Closed:Sat, 28 Oct 2017 14:29:48 -0400

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Thu, 26 Oct 2017 05:17:32 -0400 Michał Kępień <michal@isc.org> - Ticket created
Date: Thu, 26 Oct 2017 11:17:30 +0200
To: bind9-public@isc.org
Subject: Fix misleading parts of keytable unit tests
From: michal@isc.org

Certain comments and checks in keytable unit tests are misleading and thus should be fixed or removed.
  Thu, 26 Oct 2017 05:22:23 -0400 Michał Kępień <michal@isc.org> - Correspondence added

Please review rt46407. See commit messages for the motivation behind each change.
Thu, 26 Oct 2017 05:22:24 -0400 Michał Kępień <michal@isc.org> - Status changed from 'open' to 'review'
Thu, 26 Oct 2017 05:22:24 -0400 Michał Kępień <michal@isc.org> - Untaken
  Fri, 27 Oct 2017 18:51:51 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

This looks fine, okay to merge. While backporting it, you might want to see whether any of the unit tests from 46267 should be backported as well.
Fri, 27 Oct 2017 18:51:51 -0400 Evan Hunt <Evan_Hunt@isc.org> - Given to Michał Kępień <michal@isc.org>
  Sat, 28 Oct 2017 14:28:48 -0400 Michał Kępień <michal@isc.org> - Correspondence added

Thanks for the suggestion. Backporting the keytable unit tests added by rt46267 to v9_11 requires stripping them from key node trust status checks. I did that as an experiment and it turned out that the added tests basically became duplicates of the already existing ones. Also, adding them would place an additional backporting burden on us in case we want to modify these tests in the future. Given all the above, I decided against backporting unit test changes from rt46267 and I just applied changes from rt46407.
  Sat, 28 Oct 2017 14:29:47 -0400 Michał Kępień <michal@isc.org> - Correspondence added

4799. [cleanup] Improve clarity of keytable unit tests. [RT #46407] 9.11.3, 9.12.0
Sat, 28 Oct 2017 14:29:48 -0400 Michał Kępień <michal@isc.org> - Status changed from 'review' to 'resolved'
Sat, 28 Oct 2017 14:29:48 -0400 Michał Kępień <michal@isc.org> - Version Fixed 9.11.3, 9.12.0 added