Report information
The Basics
Id:
46430
Status:
resolved
Priority:
Low/Low
Queue:
bind9-public
People
BugTracker
Version Fixed:
9.11.3, 9.10.7, 9.9.12
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
test
Dates
Created:Mon, 30 Oct 2017 05:02:15 -0400
Updated:Tue, 31 Oct 2017 03:02:50 -0400
Closed:Tue, 31 Oct 2017 03:02:50 -0400

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Mon, 30 Oct 2017 05:02:17 -0400 Michał Kępień <michal@isc.org> - Ticket created
To: bind9-public@isc.org
From: michal@isc.org
Date: Mon, 30 Oct 2017 10:02:14 +0100
Subject: Backport parts of RT #45293 and RT #46267 to maintenance branches

RT #46267 introduced a couple of useful system tests, but it was only applied to master. The same branch also fixed RT #46055 (which was merged with #46077, from which RT #46267 was split off), which means the fix has not been backported to maintenance branches. However, the differences between master and older branches will require tweaking certain tests, removing some of them altogether and other customizations. This effort will be tracked in this ticket.
Mon, 30 Oct 2017 05:02:45 -0400 Michał Kępień <michal@isc.org> - Reference to #45293: mkeys system test fails added
Mon, 30 Oct 2017 05:02:46 -0400 Michał Kępień <michal@isc.org> - Reference to #46077: added
Mon, 30 Oct 2017 05:02:46 -0400 Michał Kępień <michal@isc.org> - Reference to #46267: added
  Mon, 30 Oct 2017 07:18:24 -0400 Michał Kępień <michal@isc.org> - Correspondence added

Apart from adding new system tests, RT #45293 also brings significant improvements to speed and reliability of mkeys system test, which is yet another reason to backport it.
  Mon, 30 Oct 2017 10:11:09 -0400 Michał Kępień <michal@isc.org> - Correspondence added

Please review rt46430. It is based on v9_11 and contains a step-by-step account of the backporting process. All changes in rt46430 should be applied to v9_11, while v9_10 and v9_9 will only need the fix for RT #46055 (one-line change to lib/dns/zone.c) as the mkeys system test did not exist until 9.11. I put the updated mkeys test from the v9_11 branch on a spin for two hours on Fedora 25, FreeBSD 11.0 and OpenBSD 6.1 VMs and no issues were exposed, so I expect the branch to be at least relatively stable.
Mon, 30 Oct 2017 10:11:09 -0400 Michał Kępień <michal@isc.org> - Status changed from 'open' to 'review'
Mon, 30 Oct 2017 10:11:09 -0400 Michał Kępień <michal@isc.org> - Untaken
  Mon, 30 Oct 2017 21:54:34 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

Reviewed each change, and confirmed tests pass. Okay to commit.
Mon, 30 Oct 2017 21:54:35 -0400 Evan Hunt <Evan_Hunt@isc.org> - Given to Michał Kępień <michal@isc.org>
  Tue, 31 Oct 2017 03:02:50 -0400 Michał Kępień <michal@isc.org> - Correspondence added

4803. [bug] Backport parts of RT #45293 and RT #46267, specifically the fix for RT #46055 and mkeys system test improvements. [RT #46430] 9.11.3, 9.10.7, 9.9.12
Tue, 31 Oct 2017 03:02:50 -0400 Michał Kępień <michal@isc.org> - Status changed from 'review' to 'resolved'
Tue, 31 Oct 2017 03:02:50 -0400 Michał Kępień <michal@isc.org> - Version Fixed 9.11.3, 9.10.7, 9.9.12 added