Report information
The Basics
Id:
46973
Status:
resolved
Priority:
Medium/Medium
Queue:
bind9-public
People
Owner:
Nobody in particular
Requestors:
Petr Menšík <pemensik@redhat.com>
Cc:
AdminCc:
BugTracker
Version Fixed:
9.9.12, 9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.1, 9.13.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
bug
Attachments
0001-Fix-machine-portability-issues-fixes-unit-tests-on-n.patch
Dates
Created:Tue, 09 Jan 2018 16:25:20 -0500
Updated:Tue, 09 Jan 2018 17:53:28 -0500
Closed:Tue, 09 Jan 2018 17:53:27 -0500

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Tue, 09 Jan 2018 16:25:20 -0500 Petr Menšík <pemensik@redhat.com> - Ticket created
Date: Tue, 9 Jan 2018 22:25:11 +0100
Subject: unit tests are not passing on non-x86 arch
To: bind9-bugs@isc.org
From: "Petr Menšík" <pemensik@redhat.com>

Hello! Thanks a lot for incorporation of kyua tool. Now it is quite simple to run FAST unit tests for each build. However all builds of 9.11.2 failed to pass tests, except x86_64 build. I found some portability errors that makes them fail, here is the fix. One is related to default (unsigned) char on a platform (I cannot remember which one it was). Another issue with isc_crc64 on big endian machine like s390x. Tested was 9.11.2 release on Fedora 27, quick adjustment was made to master branch. I did also backport fixes in lib/isc/tests/ht_test:isc_ht_iterator in Fedora. Is it possible to backport it in next LTS minor release? It always fails on 32 bit platform. Long term supported version might be worth having unit tests that passes by default :) Best Regards, Petr -- Petr Menšík Software Engineer Red Hat, http://www.redhat.com/ email: pemensik@redhat.com PGP: 65C6C973
0001-Fix-machine-portability-issues-fixes-unit-tests-on-n.patch

Message body is not shown because sender requested not to inline it.

  Tue, 09 Jan 2018 17:45:28 -0500 Mark Andrews <marka@isc.org> - Correspondence added
Date: Wed, 10 Jan 2018 09:45:22 +1100
Subject: Re: [ISC-Bugs #46973] unit tests are not passing on non-x86 arch
To: bind9-confidential@isc.org
From: "Mark Andrews" <marka@isc.org>

Went with: @@ -1835,7 +1835,8 @@ ATF_TC_BODY(isc_crc64, tc) { testcase->input_len); } isc_crc64_final(&crc); - tohexstr((unsigned char *) &crc, sizeof(crc), str, sizeof(str)); + snprintf(str, sizeof(str), + "0x%016" ISC_PRINT_QUADFORMAT "X", crc); ATF_CHECK_STREQ(str, testcase->result); and appropriate changes to the expected output strings. -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org
Tue, 09 Jan 2018 17:45:29 -0500 The RT System itself - Status changed from 'new' to 'open'
Tue, 09 Jan 2018 17:49:20 -0500 Mark Andrews <marka@isc.org> - Area bug added
Tue, 09 Jan 2018 17:49:20 -0500 Mark Andrews <marka@isc.org> - Priority P2 Normal added
Tue, 09 Jan 2018 17:49:20 -0500 Mark Andrews <marka@isc.org> - Severity S2 Normal added
Tue, 09 Jan 2018 17:49:21 -0500 Mark Andrews <marka@isc.org> - Status changed from 'open' to 'resolved'
Tue, 09 Jan 2018 17:49:21 -0500 Mark Andrews <marka@isc.org> - Queue changed from #6 to bind9-public
Tue, 09 Jan 2018 17:52:49 -0500 Mark Andrews <marka@isc.org> - Version Fixed 9.9.12, 9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.1, 9.13.0 added
  Tue, 09 Jan 2018 17:53:11 -0500 Mark Andrews <marka@isc.org> - Correspondence added

4861. [bug] The isc_crc64 unit test was not endian independent. [RT #46973] 4860. [bug] isc_int8_t should be signed char. [RT #46973]
Tue, 09 Jan 2018 17:53:12 -0500 The RT System itself - Status changed from 'resolved' to 'open'
Tue, 09 Jan 2018 17:53:28 -0500 Mark Andrews <marka@isc.org> - Status changed from 'open' to 'resolved'