Report information
The Basics
Id:
46553
Status:
resolved
Priority:
Low/Low
Queue:
bind9-public
People
Owner:
Nobody in particular
Requestors:
Mark Andrews <marka@isc.org>
Cc:
AdminCc:
BugTracker
Version Fixed:
9.10.7, 9.10.7(sub), 9.11.3, 9.12.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
libdns
Dates
Created:Fri, 10 Nov 2017 00:03:53 -0500
Updated:Sun, 12 Nov 2017 23:29:56 -0500
Closed:Sun, 12 Nov 2017 23:29:21 -0500

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Fri, 10 Nov 2017 00:03:53 -0500 Mark Andrews <marka@isc.org> - Ticket created
To: bind9-public@isc.org
Subject: rbt_test:insert_and_delete is wrong.
From: marka@isc.org
Date: Thu, 09 Nov 2017 19:03:53 -1000

insert_and_delete calls dns_rbt_addname which updates node->data on ISC_R_EXISTS and then returns ISC_R_SUCCESS. This results in the expected node count not matching the reported node count.
  Fri, 10 Nov 2017 00:06:49 -0500 Mark Andrews <marka@isc.org> - Correspondence added

ready for review.
Fri, 10 Nov 2017 00:06:50 -0500 The RT System itself - Status changed from 'new' to 'open'
Fri, 10 Nov 2017 00:06:50 -0500 Mark Andrews <marka@isc.org> - Status changed from 'open' to 'review'
  Fri, 10 Nov 2017 17:09:54 -0500 Mukund Sivaraman <muks@isc.org> - Correspondence added
Date: Sat, 11 Nov 2017 06:09:28 +0800
To: "Mark Andrews via RT" <bind9-public@isc.org>
From: "Mukund Sivaraman" <muks@isc.org>
Subject: Re: [ISC-Bugs #46553] rbt_test:insert_and_delete is wrong.

On Fri, Nov 10, 2017 at 05:03:54AM +0000, Mark Andrews via RT wrote: > insert_and_delete calls dns_rbt_addname which updates node->data on > ISC_R_EXISTS and then returns ISC_R_SUCCESS. This results in the > expected node count not matching the reported node count. The branch looks good and is correct. The previous code was incorrect. Was this case reached btw? It looks very unlikely that two 32-byte long random alphabetic names will have a collision when 1024 names are inserted into the tree. Mukund
Fri, 10 Nov 2017 17:11:42 -0500 Mukund Sivaraman <muks@isc.org> - Given to Mark Andrews <marka@isc.org>
  Fri, 10 Nov 2017 20:48:34 -0500 Mark Andrews <marka@isc.org> - Correspondence added
From: "Mark Andrews" <marka@isc.org>
Date: Sat, 11 Nov 2017 12:48:24 +1100
Subject: Re: [ISC-Bugs #46553] [Owner Change] rbt_test:insert_and_delete is wrong.
To: bind9-public@isc.org

We have had this test fail several times. Whether it was this cause or not I’m not sure. We do however need to fix the test to find out if there is a underlying bug. -- Mark Andrews > On 11 Nov 2017, at 09:11, Mukund Sivaraman via RT <bind9-public@isc.org> wrote: > > On Fri Nov 10 22:11:42 2017, ownership of ticket #46553 with a subject of: > > "rbt_test:insert_and_delete is wrong." > > passed to marka. For more information about this ticket, visit: > https://bugs.isc.org/Ticket/Display.html?id=46553
Sun, 12 Nov 2017 23:29:18 -0500 Mark Andrews <marka@isc.org> - Version Fixed 9.10.7, 9.10.7(sub), 9.11.3, 9.12.0 added
  Sun, 12 Nov 2017 23:29:19 -0500 Mark Andrews <marka@isc.org> - Correspondence added

4815. [bug] rbt_test.c:insert_and_delete needed to call dns_rbt_addnode instead of dns_rbt_addname. [RT #46553]
Sun, 12 Nov 2017 23:29:21 -0500 Mark Andrews <marka@isc.org> - Status changed from 'review' to 'resolved'
Sun, 12 Nov 2017 23:29:21 -0500 Mark Andrews <marka@isc.org> - Given to Brian Conry <bconry@isc.org>
Sun, 12 Nov 2017 23:29:38 -0500 Mark Andrews <marka@isc.org> - Stolen from Brian Conry <bconry@isc.org>
Sun, 12 Nov 2017 23:29:56 -0500 Mark Andrews <marka@isc.org> - Untaken