Report information
The Basics
Id:
46966
Status:
review
Priority:
Low/Low
Queue:
bind9-public
People
Owner:
Mukund Sivaraman <muks@isc.org>
Requestors:
Cc:
AdminCc:
BugTracker
Version Fixed:
(no value)
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
(no value)
Severity:
(no value)
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
feature
Dates
Created:Mon, 08 Jan 2018 13:26:39 -0500
Updated:Fri, 19 Jan 2018 02:36:42 -0500
Closed:Not set

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Mon, 08 Jan 2018 13:26:40 -0500 Mukund Sivaraman <muks@isc.org> - Ticket created
Subject: Don't re-use nonce when processing multiple rndc requests on same connection
From: "Mukund Sivaraman" <muks@isc.org>
Date: Mon, 8 Jan 2018 23:56:29 +0530
To: bind9-public@isc.org

Mon, 08 Jan 2018 13:41:26 -0500 Mukund Sivaraman <muks@isc.org> - Status changed from 'new' to 'review'
  Mon, 08 Jan 2018 14:49:19 -0500 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

This looks fine to me.
Mon, 08 Jan 2018 14:49:20 -0500 Evan Hunt <Evan_Hunt@isc.org> - Given to Mukund Sivaraman <muks@isc.org>
  Mon, 15 Jan 2018 18:55:51 -0500 Mark Andrews <marka@isc.org> - Correspondence added

Making the nonce change will prevent pipelining of updates over the control channel.
  Wed, 17 Jan 2018 22:54:57 -0500 Mukund Sivaraman <muks@isc.org> - Correspondence added
Date: Thu, 18 Jan 2018 09:24:41 +0530
To: "Mark Andrews via RT" <bind9-public@isc.org>
Subject: Re: [ISC-Bugs #46966] Don't re-use nonce when processing multiple rndc requests on same connection
From: "Mukund Sivaraman" <muks@isc.org>

On Mon, Jan 15, 2018 at 11:55:52PM +0000, Mark Andrews via RT wrote: > Making the nonce change will prevent pipelining of updates over the > control channel. Would you be fine with incrementing the nonce on every subsequent query? Mukund
  Thu, 18 Jan 2018 03:49:04 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Thu Jan 18 03:54:57 2018, muks wrote: > Would you be fine with incrementing the nonce on every subsequent query? => a nonce must be not predictable so I am afraid it is not fine (note I said not predictable vs random as it is the wanted property and to take the nonce content from a random generator is only the common way to guarantee the property).
  Thu, 18 Jan 2018 18:06:40 -0500 Mark Andrews <marka@isc.org> - Correspondence added
From: "Mark Andrews" <marka@isc.org>
Subject: Re: [ISC-Bugs #46966] Don't re-use nonce when processing multiple rndc requests on same connection
To: bind9-public@isc.org
Date: Fri, 19 Jan 2018 10:06:33 +1100

We do not need to change the session nonce. A simple sequence number will prevent replay insertion into the stream and we have that in “_ser” which rndc increases on every transaction. The server is already looking for replays and rejects them. bin/rndc/rndc.c: DO("create message", isccc_cc_createmessage(1, NULL, NULL, ++serial, bin/rndc/rndc.c: DO("create message", isccc_cc_createmessage(1, NULL, NULL, ++serial, > On 18 Jan 2018, at 7:49 pm, Francis Dupont via RT <bind9-public@isc.org> wrote: > > On Thu Jan 18 03:54:57 2018, muks wrote: >> Would you be fine with incrementing the nonce on every subsequent query? > > => a nonce must be not predictable so I am afraid it is not fine > (note I said not predictable vs random as it is the wanted property > and to take the nonce content from a random generator is > only the common way to guarantee the property). > > > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46966 -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org
  Fri, 19 Jan 2018 02:36:41 -0500 Ray Bellis <ray@isc.org> - Correspondence added
Date: Fri, 19 Jan 2018 07:36:42 +0000
To: bind9-public@isc.org
Subject: Re: [ISC-Bugs #46966] Don't re-use nonce when processing multiple rndc requests on same connection
From: "Ray Bellis" <ray@isc.org>

On 18/01/2018 23:06, Mark Andrews via RT wrote: > We do not need to change the session nonce. A simple sequence number > will prevent replay insertion into the stream and we have that in > “_ser” which rndc increases on every transaction. The server is > already looking for replays and rejects them. AFAICS that's only happening in the code that's commented as being necessary for UDP packet duplication, which is what raised this discussion in the first place since we don't use UDP for RNDC. If that code is *not* just for UDP, could the comments please be fixed?