Report information
The Basics
Id:
33098
Status:
resolved
Estimated:
36 hours (2,160 minutes)
Left:
36 hours (2,160 minutes)
Priority:
Low/Low
Queue:
dhcp-public
People
Owner:
Nobody in particular
Requestors:
Tomas Hozza <thozza@redhat.com>
Cc:
AdminCc:
BugTracker
Version Fixed:
4.3.1, 4.2.7, 4.1-ESV-R10
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P1 High
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
feature
Attachments
0001-Expose-next-server-DHCPv4-option-to-dhclient-script.patch 0xC5887AD51D9F3C2D.asc
Dates
Created:Wed, 03 Apr 2013 11:51:55 -0400
Updated:Mon, 15 Jan 2018 14:55:19 -0500
Closed:Fri, 01 Dec 2017 08:56:11 -0500

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Wed, 03 Apr 2013 11:51:56 -0400 Tomas Hozza <thozza@redhat.com> - Ticket created
CC: Jiri Popelka <jpopelka@redhat.com>
Subject: dhclient does not exposes next-server DHCPv4 option to dhclient script
Date: Wed, 3 Apr 2013 11:51:49 -0400 (EDT)
To: dhcp-bugs@isc.org
From: Tomas Hozza <thozza@redhat.com>

Hello. Currently dhclient does not exposes next-server DHCPv4 option to the dhclient script. Patch fixing this is attached (based on latest dhcp-4.2.5). Regards, Tomas Hozza
0001-Expose-next-server-DHCPv4-option-to-dhclient-script.patch

Message body is not shown because sender requested not to inline it.

Fri, 12 Apr 2013 10:22:07 -0400 Brian Conry <bconry@isc.org> - Queue changed from #8 to #10
Fri, 12 Apr 2013 10:27:07 -0400 Brian Conry <bconry@isc.org> - Priority P2 Normal added
Fri, 12 Apr 2013 10:28:37 -0400 Brian Conry <bconry@isc.org> - Status changed from 'new' to 'open'
Fri, 12 Apr 2013 10:29:10 -0400 Brian Conry <bconry@isc.org> - Priority P2 Normal deleted
Fri, 12 Apr 2013 10:29:10 -0400 Brian Conry <bconry@isc.org> - Severity S2 Normal added
  Fri, 12 Apr 2013 10:41:02 -0400 Brian Conry <bconry@isc.org> - Correspondence added

On Wed Apr 03 15:51:56 2013, thozza@redhat.com wrote:
> Hello.
>
> Currently dhclient does not exposes next-server DHCPv4
> option to the dhclient script. Patch fixing this is
> attached (based on latest dhcp-4.2.5).
>
> Regards,
>
> Tomas Hozza

Hi Tomas,

Thanks for submitting this patch!

Our engineering team will review it and consider it for inclusion in a future release.

Thanks,
Brian Conry

  Thu, 01 May 2014 13:12:27 -0400 Shawn Routhier <sar@isc.org> - Correspondence added

We are (finally) looking at adding this ticket to our code.
I'm a bit concerned about porting it into 4.1 and 4.2 as it
changes what the user experience is a bit.  

I believe it makes sense to add this to 4.3.1 but 
I'd like to hear your thoughts on including this functionality
into 4.1 or 4.2.  Are you already including it?  have you seen
any problems with script mis-behavior?

I do plan to change the patch somewhat, basically adding
a server_address type field into the client lease structure
and treating it similar to the address field rather than passing
the server address as an argument.

Shawn
Thu, 01 May 2014 14:22:27 -0400 Shawn Routhier <sar@isc.org> - Dependency on #18933: added
  Mon, 05 May 2014 03:26:12 -0400 Tomas Hozza <thozza@redhat.com> - Correspondence added
CC: Jiri Popelka <jpopelka@redhat.com>
Subject: Re: [ISC-Bugs #33098] dhclient does not exposes next-server DHCPv4 option to dhclient script
Date: Mon, 5 May 2014 03:26:10 -0400 (EDT)
To: dhcp-suggest@isc.org
From: Tomas Hozza <thozza@redhat.com>

Hi Shawn. ----- Original Message ----- > We are (finally) looking at adding this ticket to our code. > I'm a bit concerned about porting it into 4.1 and 4.2 as it > changes what the user experience is a bit. > > I believe it makes sense to add this to 4.3.1 but > I'd like to hear your thoughts on including this functionality > into 4.1 or 4.2. Are you already including it? have you seen > any problems with script mis-behavior? We are already including the patch in RHEL-6 shipping the 4.1.1-P1 version. AFAIK there have been no complains or mis-behaviour caused by the patch. The patch is also included since Fedora 18 which shipped the 4.2.5 version. I'm CC-ing Jirka Popelka, the maintainer of ISC DHCP server in RHEL/Fedora. > I do plan to change the patch somewhat, basically adding > a server_address type field into the client lease structure > and treating it similar to the address field rather than passing > the server address as an argument. > > Shawn This sounds reasonable. Since the exposed option name/format should be the same it will not cause behaviour change compared to my original patch. Thank you for reviewing the patch and letting us know. Regards, -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com
  Wed, 07 May 2014 11:56:20 -0400 Shawn Routhier <sar@isc.org> - Correspondence added

 The first half of this has been committed  to
master => 4.3.1 first
4.2 => 4.2.7 first
4.1-ESV => 4.1-ESV-R10 first

I'm leaving the ticket open until the second half (write
to and read from lease file) is completed.

Tue, 02 Sep 2014 17:46:09 -0400 Vicky Risk <vicky@isc.org> - Priority P1 High added
Tue, 02 Sep 2014 17:46:09 -0400 Vicky Risk <vicky@isc.org> - Versions Planned 4.3.2 added
Mon, 23 Mar 2015 21:12:22 -0400 Shawn Routhier <sar@isc.org> - FinalPriority changed from 'Medium' to 'Low'
Mon, 23 Mar 2015 21:12:22 -0400 Shawn Routhier <sar@isc.org> - Priority changed from 'Medium' to 'Low'
Mon, 23 Mar 2015 21:12:23 -0400 Shawn Routhier <sar@isc.org> - Versions Planned 4.3.2 changed to 4.3.3
Thu, 26 Mar 2015 22:43:36 -0400 Shawn Routhier <sar@isc.org> - TimeEstimated changed from (no value) to '2160'
Thu, 30 Jul 2015 00:54:42 -0400 Shawn Routhier <sar@isc.org> - Versions Planned 4.3.3 changed to 4.3.4
Wed, 19 Aug 2015 01:45:51 -0400 Shawn Routhier <sar@isc.org> - TimeLeft changed from (no value) to '2160'
Thu, 21 Apr 2016 12:59:57 -0400 Shawn Routhier <sar@isc.org> - Versions Planned 4.3.4 changed to 4.3.5
Wed, 30 Nov 2016 10:00:03 -0500 Thomas Markwalder <tmark@isc.org> - Versions Planned 4.3.5 changed to 4.3.6
Tue, 14 Feb 2017 14:46:18 -0500 Thomas Markwalder <tmark@isc.org> - FinalPriority changed from 'Low' to 'Low'
Tue, 14 Feb 2017 14:46:18 -0500 Thomas Markwalder <tmark@isc.org> - Priority changed from 'Low' to 'Low'
Thu, 27 Apr 2017 10:22:02 -0400 Thomas Markwalder <tmark@isc.org> - Versions Planned 4.3.6 changed to 4.4.0
Fri, 07 Jul 2017 21:15:34 -0400 Vicky Risk <vicky@isc.org> - Queue changed from #10 to dhcp-public
Fri, 07 Jul 2017 21:15:34 -0400 Vicky Risk <vicky@isc.org> - Version Fixed 4.3.1, 4.2.7, added
Fri, 07 Jul 2017 21:15:34 -0400 Vicky Risk <vicky@isc.org> - Area feature added
Fri, 07 Jul 2017 21:16:07 -0400 Vicky Risk <vicky@isc.org> - Version Fixed 4.3.1, 4.2.7, changed to 4.3.1, 4.2.7, 4.1-ESV-R10
  Wed, 29 Nov 2017 10:25:04 -0500 Thomas Markwalder <tmark@isc.org> - Correspondence added

Hello Tomas and Jiri: As you're aware, the first part of the ticket, exposing the value of siaddr to the script was done quite some time ago. We had tagged the second part of this ticket, writing the value to the client lease file, as being included in 4.4.0 (due out Q1-2018). While this isn't difficult to do, we're not sure we see the value in doing it. It is not a value dhclient uses directly other than exposing it to the script. Do either of you have a use case for it being persisted in the lease file? If not we're going to resolve this ticket as complete. Thanks Thomas Markwalder ISC Software Engineering
  Fri, 01 Dec 2017 07:19:44 -0500 Tomas Hozza <thozza@redhat.com> - Correspondence added
From: "Tomas Hozza" <thozza@redhat.com>
Subject: Re: [ISC-Bugs #33098] dhclient does not exposes next-server DHCPv4 option to dhclient script
To: dhcp-public@isc.org
CC: "Pavel Zhukov" <pzhukov@redhat.com>
Date: Fri, 1 Dec 2017 13:19:32 +0100

On 29.11.2017 16:25, Thomas Markwalder via RT wrote: > Hello Tomas and Jiri: > > As you're aware, the first part of the ticket, exposing the value of siaddr to the script was done quite some time ago. We had tagged the second part of this ticket, writing the value to the client lease file, as being included in 4.4.0 (due out Q1-2018). > > While this isn't difficult to do, we're not sure we see the value in doing it. It is not a value dhclient uses directly other than exposing it to the script. Do either of you have a use case for it being persisted in the lease file? > > If not we're going to resolve this ticket as complete. > > Thanks > > Thomas Markwalder > ISC Software Engineering Hello Thomas. I had to check back our original issue https://bugzilla.redhat.com/show_bug.cgi?id=658855. Based on the information I was able to find, I think we cared only about dhclient exposing the value. Therefore I agree with you assessment, that storing the value in the lease file should not be necessary. Thank you for checking with us. Regards, Tomas -- Tomas Hozza Associate Manager, Software Engineering - EMEA ENG Core Services PGP: 1D9F3C2D UTC+1 (CET) Red Hat Inc. http://cz.redhat.com
0xC5887AD51D9F3C2D.asc

Message body not shown because it is not plain text.

Fri, 01 Dec 2017 08:56:11 -0500 Thomas Markwalder <tmark@isc.org> - Status changed from 'open' to 'resolved'
Fri, 01 Dec 2017 09:01:47 -0500 Thomas Markwalder <tmark@isc.org> - Versions Planned 4.4.0 deleted
Mon, 15 Jan 2018 14:55:19 -0500 Vicky Risk <vicky@isc.org> - Subject changed from 'dhclient does not exposes next-server DHCPv4 option to dhclient script' to '[patch] dhclient does not exposes next-server DHCPv4 option to dhclient script'