Bug #35989 for dhcp-public: dhclient-4.3.0 fails to start when resolv.conf contains nameserver with '%' scope-delimiter

Tue, 13 May 2014 08:55:28 -0400 Jiri Popelka <jpopelka@redhat.com> - Ticket created

CC:	thozza@redhat.com
Subject:	dhclient-4.3.0 fails to start when resolv.conf contains nameserver with '%' scope-delimiter
Date:	Tue, 13 May 2014 14:55:12 +0200
To:	dhcp-bugs@isc.org
From:	Jiri Popelka <jpopelka@redhat.com>

Hi, please see original bug reports: https://bugzilla.redhat.com/show_bug.cgi?id=1057298#c5 https://bugzilla.redhat.com/show_bug.cgi?id=1093294#c4 I think the libirs' resconf code needs to treat the '%' scope-delimiter similar way glibc does, see attached patch. With regards, Jiri Popelka Red Hat, inc.

0001-irs-resconf-treat-scope-delimiter-in-link-local-name.patch

Message body is not shown because sender requested not to inline it.

Tue, 13 May 2014 09:02:28 -0400 Mark Andrews <marka@isc.org> - Correspondence added

Subject:	Re: [ISC-Bugs #35989] dhclient-4.3.0 fails to start when resolv.conf contains nameserver with '%' scope-delimiter
Date:	Tue, 13 May 2014 23:02:12 +1000
To:	dhcp-bugs@isc.org
From:	Mark Andrews <marka@isc.org>

In message <rt-3.8.6-35138-1399985728-1722.35989-3-0@isc.org>, "Jiri Popelka via RT" writes: > > Hi, > > please see original bug reports: > https://bugzilla.redhat.com/show_bug.cgi?id=1057298#c5 > https://bugzilla.redhat.com/show_bug.cgi?id=1093294#c4 > > I think the libirs' resconf code needs to treat the '%' scope-delimiter > similar way glibc does, see attached patch. > > With regards, > Jiri Popelka > Red Hat, inc. The patch modifies a const char * string. -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org

Tue, 13 May 2014 09:02:28 -0400 The RT System itself - Status changed from 'new' to 'open'

Tue, 13 May 2014 09:25:59 -0400 Jiri Popelka <jpopelka@redhat.com> - Correspondence added

CC:	thozza@redhat.com
Subject:	Re: [ISC-Bugs #35989] dhclient-4.3.0 fails to start when resolv.conf contains nameserver with '%' scope-delimiter
Date:	Tue, 13 May 2014 15:25:44 +0200
To:	dhcp-bugs@isc.org
From:	Jiri Popelka <jpopelka@redhat.com>

On 05/13/2014 03:02 PM, Mark Andrews via RT wrote: > The patch modifies a const char * string. Oh, sure, then maybe just move the fix into resconf_parsenameserver() ? I'm sure you'll find something better, it was just a suggestion. -- Jiri

Thu, 15 May 2014 09:26:21 -0400 Brian Conry <bconry@isc.org> - Severity S1 High added

Fri, 16 May 2014 07:30:14 -0400 Tomas Hozza <thozza@redhat.com> - Correspondence added

CC:	Jiri Popelka <jpopelka@redhat.com>
Subject:	Re: [ISC-Bugs #35989] dhclient-4.3.0 fails to start when resolv.conf contains nameserver with '%' scope-delimiter
Date:	Fri, 16 May 2014 07:30:07 -0400 (EDT)
To:	dhcp-bugs <dhcp-bugs@isc.org>, bind9-bugs@isc.org
From:	Tomas Hozza <thozza@redhat.com>

I'm sending fixed patch. The code has been moved to resconf_parsenameserver() function. ----- Original Message ----- > On 05/13/2014 03:02 PM, Mark Andrews via RT wrote: > > The patch modifies a const char * string. > > Oh, sure, then maybe just move the fix into resconf_parsenameserver() ? > I'm sure you'll find something better, it was just a suggestion. > > -- > Jiri > Regards, -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com

0001-irs-resconf-treat-scope-delimiter-in-link-local-name.patch

Message body is not shown because sender requested not to inline it.

Fri, 16 May 2014 07:30:14 -0400 Tomas Hozza <thozza@redhat.com> - Correspondence added

CC:	Jiri Popelka <jpopelka@redhat.com>
Subject:	Re: [ISC-Bugs #35989] dhclient-4.3.0 fails to start when resolv.conf contains nameserver with '%' scope-delimiter
Date:	Fri, 16 May 2014 07:30:07 -0400 (EDT)
To:	dhcp-bugs <dhcp-bugs@isc.org>, bind9-bugs@isc.org
From:	Tomas Hozza <thozza@redhat.com>

I'm sending fixed patch. The code has been moved to resconf_parsenameserver() function. ----- Original Message ----- > On 05/13/2014 03:02 PM, Mark Andrews via RT wrote: > > The patch modifies a const char * string. > > Oh, sure, then maybe just move the fix into resconf_parsenameserver() ? > I'm sure you'll find something better, it was just a suggestion. > > -- > Jiri > Regards, -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com

0001-irs-resconf-treat-scope-delimiter-in-link-local-name.patch

Message body is not shown because sender requested not to inline it.

Mon, 19 May 2014 17:29:44 -0400 Shawn Routhier <sar@isc.org> - Reference by #36039: issues with % in scope in resolve.conf added

Mon, 19 May 2014 18:41:41 -0400 Shawn Routhier <sar@isc.org> - Queue changed from #8 to #9

Mon, 19 May 2014 18:43:27 -0400 Shawn Routhier <sar@isc.org> - Correspondence added

I've queue up a patch for 4.3.1 first that is awaiting review it has the
dhcp process continue running even if it the code can't handle resolv.conf.

diff --git a/omapip/isclib.c b/omapip/isclib.c

index 59332ed..ce6d505 100644

--- a/omapip/isclib.c

+++ b/omapip/isclib.c

@@ -225,9 +225,17 @@ dhcp_context_create(int flags,

if (result != ISC_R_SUCCESS)

goto cleanup;

+ /*

+ * If we can't set up the servers we may not be able to

+ * do DDNS but we should continue to try and perform

+ * our basic functions and let the user sort it out.

+ */

result = dhcp_dns_client_setservers();

- if (result != ISC_R_SUCCESS)

- goto cleanup;

+ if (result != ISC_R_SUCCESS) {

+ log_error("Unable to set resolver from resolv.conf "

+ "continuing to start up but DDNS support "

+ "may be affected");

+ }

}

#endif

Tue, 20 May 2014 05:42:54 -0400 Stephen Morris <stephen@isc.org> - Taken

Tue, 20 May 2014 06:21:40 -0400 Stephen Morris <stephen@isc.org> - Given to Shawn Routhier <sar@isc.org>

Tue, 20 May 2014 22:37:52 -0400 Shawn Routhier <sar@isc.org> - Status changed from 'open' to 'resolved'

Tue, 20 May 2014 22:38:55 -0400 Shawn Routhier <sar@isc.org> - Dependency by #35840: added

Fri, 18 Jul 2014 07:00:40 -0400 Tomas Hozza <thozza@redhat.com> - Correspondence added

Subject:	Re: [ISC-Bugs #35989] dhclient-4.3.0 fails to start when resolv.conf contains nameserver with '%' scope-delimiter
Date:	Fri, 18 Jul 2014 07:00:36 -0400 (EDT)
To:	bind9-bugs@isc.org
From:	Tomas Hozza <thozza@redhat.com>

----- Original Message ----- > I'm sending fixed patch. The code has been moved to resconf_parsenameserver() > function. > > ----- Original Message ----- > > On 05/13/2014 03:02 PM, Mark Andrews via RT wrote: > > > The patch modifies a const char * string. > > > > Oh, sure, then maybe just move the fix into resconf_parsenameserver() ? > > I'm sure you'll find something better, it was just a suggestion. > > > > -- > > Jiri > > Hi. We would like to fix this issue in Fedora. We didn't hear anything from you about this bug since I sent you the fixed patch. I would like to ask if there are any problems that we can work out, for the patch to be merged? Thank you. Regards, -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com

Fri, 18 Jul 2014 07:00:40 -0400 The RT System itself - Status changed from 'resolved' to 'open'

Fri, 18 Jul 2014 12:58:42 -0400 Shawn Routhier <sar@isc.org> - Correspondence added

I apologize, I thought I had included you on the changes to this
ticket but see that I didn't do so.

We have included a patch to address this issue already. It
went into the 4.3 branch and was released as part of 4.3.1b1.
This patch simply allows the DHCP server to continue running
even if the resolver config file can't be read.

I also passed the issue along to the Bind9 people. I'm not
sure when they will address the issue and depending on
when they address it when that fix will get included with
DHCP as we pull in their libraries.

regards,
Shawn

On Fri Jul 18 11:00:40 2014, thozza@redhat.com wrote:
> ----- Original Message -----
> > I'm sending fixed patch. The code has been moved to
> resconf_parsenameserver()
> > function.
> >
> > ----- Original Message -----
> > > On 05/13/2014 03:02 PM, Mark Andrews via RT wrote:
> > > > The patch modifies a const char * string.
> > >
> > > Oh, sure, then maybe just move the fix into
> resconf_parsenameserver() ?
> > > I'm sure you'll find something better, it was just a suggestion.
> > >
> > > --
> > > Jiri
> > >
>
> Hi.
>
> We would like to fix this issue in Fedora. We didn't hear anything
> from you
> about this bug since I sent you the fixed patch.
>
> I would like to ask if there are any problems that we can work out,
> for the patch to be merged?
>
> Thank you.
>
> Regards,

Tue, 12 Aug 2014 23:39:03 -0400 Shawn Routhier <sar@isc.org> - Status changed from 'open' to 'resolved'

Wed, 21 Jun 2017 15:40:11 -0400 Brian Conry <bconry@isc.org> - Queue changed from #9 to #8

Wed, 21 Jun 2017 15:40:11 -0400 The RT System itself - Owner forcibly changed from Shawn Routhier <sar@isc.org> to Nobody in particular

Fri, 07 Jul 2017 20:19:38 -0400 Vicky Risk <vicky@isc.org> - Queue changed from #8 to dhcp-public

Fri, 07 Jul 2017 20:19:38 -0400 Vicky Risk <vicky@isc.org> - Version Fixed 4.3.1 added

Created:	Tue, 13 May 2014 08:55:28 -0400
Updated:	Fri, 07 Jul 2017 20:19:38 -0400
Closed:	Tue, 12 Aug 2014 23:39:03 -0400

Bug #35989 for dhcp-public: dhclient-4.3.0 fails to start when resolv.conf contains nameserver with '%' scope-delimiter

This bug tracker is no longer active.