Bug #45490 for bind9-public: tsig.c refactoring

Fri, 30 Jun 2017 10:17:15 -0400 Ray Bellis <ray@isc.org> - Ticket created

Date:	Fri, 30 Jun 2017 14:17:15 +0000
From:	ray@isc.org
Subject:	tsig.c refactoring
To:	bind9-confidential@isc.org

Minor refactoring of lib/dns/tsig.c to reduce code duplication and simplify the disabling of MD5. The patch subsumes RT#45409 "typo in DNS_NAME_INITABSOLUTE"

Fri, 30 Jun 2017 10:31:23 -0400 Ray Bellis <ray@isc.org> - Correspondence added

> The patch subsumes RT#45409 "typo in DNS_NAME_INITABSOLUTE" or not, since that already got done in the master branch.

Fri, 30 Jun 2017 10:31:24 -0400 The RT System itself - Status changed from 'new' to 'open'

Thu, 13 Jul 2017 13:43:18 -0400 Ray Bellis <ray@isc.org> - Status changed from 'open' to 'review'

Thu, 13 Jul 2017 13:43:18 -0400 Ray Bellis <ray@isc.org> - Priority P3 Low changed to P2 Normal

Fri, 14 Jul 2017 01:15:57 -0400 Evan Hunt <Evan_Hunt@isc.org> - Given to Ray Bellis <ray@isc.org>

Fri, 14 Jul 2017 04:44:02 -0400 The RT System itself - Subject changed from 'tsig.c refactoring' to 'tsig.c refactoring [ISC-Bugs #45490]'

Fri, 21 Jul 2017 12:42:19 -0400 Brian Conry <bconry@isc.org> - Subject changed from 'tsig.c refactoring [ISC-Bugs #45490]' to 'tsig.c refactoring'

Tue, 25 Jul 2017 12:38:32 -0400 Vicky Risk <vicky@isc.org> - Queue changed from #6 to bind9-public

Wed, 06 Sep 2017 13:57:19 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

After merging to current master, the version that uses #include "../tsig.c" no longer compiles due to shadowed global variables. Earlier, Mark and I discussed the best method for unit testing static functions, and he convinced me that it's okay to use the direct-include method in relatively simple cases, where the file is small and including it isn't going to cause namespace problems with the unit test. But that seems no longer to be the case here. So, because I want to get this merged for alpha, I reverted back to using double-underscore, non-static functions. However, I created a tsig_p.h instead of having the prototypes be in the public tsig.h. 4701. [cleanup] Refactored lib/dns/tsig.c to reduce code duplication and simplify the disabling of MD5. [RT #45490] 9.12.0

Wed, 06 Sep 2017 13:57:20 -0400 Evan Hunt <Evan_Hunt@isc.org> - Status changed from 'review' to 'qa'

Wed, 06 Sep 2017 13:57:29 -0400 Evan Hunt <Evan_Hunt@isc.org> - Version Fixed 9.12.0 added

Mon, 18 Sep 2017 20:19:38 -0400 Curtis Blackburn <ckb@isc.org> - Correspondence added

test is fine. resolving On Wed Sep 06 10:57:19 2017, each wrote: > After merging to current master, the version that uses #include "../tsig.c" > no longer compiles due to shadowed global variables. > > Earlier, Mark and I discussed the best method for unit testing static > functions, and he convinced me that it's okay to use the direct-include > method in relatively simple cases, where the file is small and including > it isn't going to cause namespace problems with the unit test. But that > seems no longer to be the case here. > > So, because I want to get this merged for alpha, I reverted back to using > double-underscore, non-static functions. However, I created a tsig_p.h > instead of having the prototypes be in the public tsig.h. > > 4701. [cleanup] Refactored lib/dns/tsig.c to reduce code > duplication and simplify the disabling of MD5. > [RT #45490] > > 9.12.0

Mon, 18 Sep 2017 20:19:39 -0400 Curtis Blackburn <ckb@isc.org> - Status changed from 'qa' to 'resolved'

Created:	Fri, 30 Jun 2017 10:17:15 -0400
Updated:	Mon, 18 Sep 2017 20:19:39 -0400
Closed:	Mon, 18 Sep 2017 20:19:39 -0400

Bug #45490 for bind9-public: tsig.c refactoring

This bug tracker is no longer active.