Report information
The Basics
Id:
46107
Status:
resolved
Priority:
Medium/Medium
Queue:
bind9-public
People
Owner:
Mark Andrews <marka@isc.org>
Requestors:
Ray Bellis <ray@isc.org>
Cc:
AdminCc:
BugTracker
Version Fixed:
(no value)
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
bug
Dates
Created:Tue, 26 Sep 2017 10:51:05 -0400
Updated:Tue, 30 Jan 2018 15:07:04 -0500
Closed:Thu, 28 Sep 2017 13:17:21 -0400

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Tue, 26 Sep 2017 10:51:06 -0400 Ray Bellis <ray@isc.org> - Ticket created
Date: Tue, 26 Sep 2017 15:49:06 +0100
Subject: Build errors - master with --enable-developer
From: "Ray Bellis" <ray@isc.org>
To: bind9-bugs@isc.org

On Fedora Core 26, GCC 7.1.1, configured with --enable-developer making all in /home/ray/src/bind9/lib/isc/tests make[3]: Entering directory '/home/ray/src/bind9/lib/isc/tests' ... gcc -I/home/ray/src/bind9 -I../../.. -I. -Iinclude -I/home/ray/src/bind9/lib/isc/include -I../../../lib/isc -I../../../lib/isc/include -I../../../lib/isc/unix/include -I../../../lib/isc/pthreads/include -I../../../lib/isc/x86_32/ ht_test.c: In function ‘atfu_isc_ht_iterator_body’: ht_test.c:184:49: error: ‘ key of a raw hashtable!!’ directive output truncated writing 25 bytes into a region of size between 11 and 15 [-Werror=format-truncation=] snprintf((char *)key, 16, "%lld key of a raw hashtable!!", i); ~~~~~~~~~~~~~~~^~~~~~~~~~ and then several more very similar errors before the compile craps out.
  Tue, 26 Sep 2017 18:37:33 -0400 Mark Andrews <marka@isc.org> - Correspondence added
Date: Wed, 27 Sep 2017 08:36:58 +1000
Subject: Re: [ISC-Bugs #46107] Build errors - master with --enable-developer
To: bind9-confidential@isc.org
From: "Mark Andrews" <marka@isc.org>

Can you try branch rt46107. It uses strlcat to pad the key to full size. We really need inline directives to turn of warnings like this when we know the code will produce them. -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org
Tue, 26 Sep 2017 18:37:34 -0400 The RT System itself - Status changed from 'new' to 'open'
Wed, 27 Sep 2017 00:22:48 -0400 Mark Andrews <marka@isc.org> - Status changed from 'open' to 'review'
Wed, 27 Sep 2017 00:22:49 -0400 Mark Andrews <marka@isc.org> - Priority P2 Normal added
Wed, 27 Sep 2017 00:22:49 -0400 Mark Andrews <marka@isc.org> - Severity S2 Normal added
Wed, 27 Sep 2017 00:23:21 -0400 Mark Andrews <marka@isc.org> - Queue changed from #6 to bind9-public
  Wed, 27 Sep 2017 01:18:54 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

There was a comment that was a sentence fragment. Fixed that. Otherwise it's fine, go ahead and commit.
Wed, 27 Sep 2017 01:18:55 -0400 Evan Hunt <Evan_Hunt@isc.org> - Given to Mark Andrews <marka@isc.org>
  Wed, 27 Sep 2017 03:33:15 -0400 Ray Bellis <ray@isc.org> - Correspondence added
Date: Wed, 27 Sep 2017 08:32:39 +0100
To: bind9-public@isc.org
Subject: Re: [ISC-Bugs #46107] Build errors - master with --enable-developer
From: "Ray Bellis" <ray@isc.org>

There's still (at least) one error in ht_test.c: ht_test.c:58:39: error: ‘%lld’ directive output may be truncated writing between 1 and 19 bytes into a region of size 16 [-Werror=format-truncation=] snprintf((char *)key, sizeof(key), "%lld", i); ht_test.c:58:38: note: directive argument in the range [1, 9223372036854775806] snprintf((char *)key, sizeof(key), "%lld", i); ^~~~~~
  Wed, 27 Sep 2017 03:59:25 -0400 Mark Andrews <marka@isc.org> - Correspondence added
Date: Wed, 27 Sep 2017 17:58:00 +1000
From: "Mark Andrews" <marka@isc.org>
To: bind9-public@isc.org
Subject: Re: [ISC-Bugs #46107] Build errors - master with --enable-developer

In message <rt-4.4.1-30364-1506497596-433.46107-4-0@isc.org>, "Ray Bellis via R T" writes: > There's still (at least) one error in ht_test.c: > > ht_test.c:58:39: error: ‘%lld’ directive output may be truncated writing > between 1 and 19 bytes into a region of size 16 [-Werror=format-truncation=] > snprintf((char *)key, sizeof(key), "%lld", i); > ht_test.c:58:38: note: directive argument in the range [1, > 9223372036854775806] > snprintf((char *)key, sizeof(key), "%lld", i); > ^~~~~~ Casted i to unsigned int and used "%u". > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46107 -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org
  Thu, 28 Sep 2017 13:17:20 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

This appears to have all been committed, resolving.
Thu, 28 Sep 2017 13:17:21 -0400 Evan Hunt <Evan_Hunt@isc.org> - Status changed from 'review' to 'resolved'
Tue, 30 Jan 2018 15:07:04 -0500 Michał Kępień <michal@isc.org> - Reference by #46980: added