Bug #46108 for bind9-public: JSON and XML stats channel data misrepresents shared caches

In the JSON stats channel data, each view contains a 'cachestats' element with the counters for the cache attached to the view. This happens even when the cache is shared between multiple views, with no indication in the data when this has happened. The XML stats channel data also contains a copy of the cache stats for each view, but it also adds a 'name' attribute to each 'cache' element, allowing someone using the stats data to identify when a cache is shared and which views are using it. By contrast, the named.stats output only includes one copy of the stats for each cache (for each class) no matter how many views share it. This is accomplished using the 'dns_view_iscacheshared' function. It also produces the name of the cache with every view so that sharing relationships are clear in the data. (side note: the "owning" view of a cache is not necessarily the one with the same name as the cache - it is instead the first view to attach to the cache). I've attached a named.conf and captured stats demonstrating this.

+++ Statistics Dump +++ (1506436857) ++ Incoming Requests ++ 1 QUERY ++ Incoming Queries ++ 1 A ++ Outgoing Rcodes ++ 1 NOERROR ++ Outgoing Queries ++ [View: default] 76 A 19 NS 53 AAAA [View: _bind] ++ Name Server Statistics ++ 1 IPv4 requests received 1 requests with EDNS(0) received 1 responses sent 1 responses with EDNS(0) sent 1 queries resulted in successful answer 1 queries resulted in non authoritative answer 1 queries caused recursion 1 UDP queries received ++ Zone Maintenance Statistics ++ ++ Resolver Statistics ++ [Common] [View: default] 43 IPv4 queries sent 105 IPv6 queries sent 43 IPv4 responses received 14 truncated responses received 120 query retries 4 IPv4 NS address fetches 4 IPv6 NS address fetches 32 queries with RTT 10-100ms 11 queries with RTT 100-500ms 31 bucket size 135 COOKIE send with client cookie only [View: _bind] 31 bucket size ++ Cache Statistics ++ [View: default] 172 cache hits 27 cache misses 0 cache hits (from query) 1 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 63 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 57584 cache tree memory in use 57632 cache tree highest memory in use 393216 cache heap memory total 132096 cache heap memory in use 132096 cache heap highest memory in use [View: _bind (Cache: foo)] 0 cache hits 0 cache misses 0 cache hits (from query) 0 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 0 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 29712 cache tree memory in use 29712 cache tree highest memory in use 262144 cache heap memory total 1024 cache heap memory in use 1024 cache heap highest memory in use ++ Cache DB RRsets ++ [View: default] 50 A 7 NS 48 AAAA 4 DS 13 RRSIG [View: _bind (Cache: foo)] ++ ADB stats ++ [View: default] 1021 Address hash table size 92 Addresses in hash table 1021 Name hash table size 49 Names in hash table [View: _bind] 1021 Address hash table size 1021 Name hash table size ++ Socket I/O Statistics ++ 59 UDP/IPv4 sockets opened 108 UDP/IPv6 sockets opened 25 TCP/IPv4 sockets opened 2 TCP/IPv6 sockets opened 1 Raw sockets opened 29 UDP/IPv4 sockets closed 105 UDP/IPv6 sockets closed 15 TCP/IPv4 sockets closed 105 UDP/IPv6 socket connect failures 29 UDP/IPv4 connections established 14 TCP/IPv4 connections established 2 TCP/IPv4 connections accepted 105 UDP/IPv6 send errors 30 UDP/IPv4 sockets active 3 UDP/IPv6 sockets active 13 TCP/IPv4 sockets active 2 TCP/IPv6 sockets active 1 Raw sockets active ++ Per Zone Query Statistics ++ --- Statistics Dump --- (1506436857) +++ Statistics Dump +++ (1506437081) ++ Incoming Requests ++ 1 QUERY ++ Incoming Queries ++ 1 A ++ Outgoing Rcodes ++ 1 NOERROR ++ Outgoing Queries ++ [View: tom] [View: dick] [View: harry] [View: _bind] ++ Name Server Statistics ++ 1 IPv4 requests received 1 requests with EDNS(0) received 1 responses sent 1 responses with EDNS(0) sent 1 queries resulted in successful answer 1 queries resulted in non authoritative answer 1 queries caused recursion 1 UDP queries received ++ Zone Maintenance Statistics ++ ++ Resolver Statistics ++ [Common] [View: tom] 31 bucket size [View: dick] 31 bucket size [View: harry] 31 bucket size [View: _bind] 31 bucket size ++ Cache Statistics ++ [View: tom (Cache: foo)] 0 cache hits 0 cache misses 0 cache hits (from query) 0 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 0 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 29712 cache tree memory in use 29712 cache tree highest memory in use 262144 cache heap memory total 1024 cache heap memory in use 1024 cache heap highest memory in use [View: dick (Cache: foo)] [View: harry (Cache: foo)] [View: _bind (Cache: foo)] 0 cache hits 0 cache misses 0 cache hits (from query) 0 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 0 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 29712 cache tree memory in use 29712 cache tree highest memory in use 262144 cache heap memory total 1024 cache heap memory in use 1024 cache heap highest memory in use ++ Cache DB RRsets ++ [View: tom (Cache: foo)] [View: dick (Cache: foo)] [View: harry (Cache: foo)] [View: _bind (Cache: foo)] ++ ADB stats ++ [View: tom] 1021 Address hash table size 1021 Name hash table size [View: dick] 1021 Address hash table size 1021 Name hash table size [View: harry] 1021 Address hash table size 1021 Name hash table size [View: _bind] 1021 Address hash table size 1021 Name hash table size ++ Socket I/O Statistics ++ 59 UDP/IPv4 sockets opened 108 UDP/IPv6 sockets opened 25 TCP/IPv4 sockets opened 2 TCP/IPv6 sockets opened 1 Raw sockets opened 29 UDP/IPv4 sockets closed 105 UDP/IPv6 sockets closed 17 TCP/IPv4 sockets closed 105 UDP/IPv6 socket connect failures 29 UDP/IPv4 connections established 14 TCP/IPv4 connections established 4 TCP/IPv4 connections accepted 105 UDP/IPv6 send errors 30 UDP/IPv4 sockets active 3 UDP/IPv6 sockets active 15 TCP/IPv4 sockets active 2 TCP/IPv6 sockets active 1 Raw sockets active ++ Per Zone Query Statistics ++ --- Statistics Dump --- (1506437081) +++ Statistics Dump +++ (1506437317) ++ Incoming Requests ++ 2 QUERY ++ Incoming Queries ++ 2 A ++ Outgoing Rcodes ++ 2 NOERROR ++ Outgoing Queries ++ [View: tom] 95 A 17 NS 45 AAAA [View: dick] [View: harry] [View: _bind] ++ Name Server Statistics ++ 2 IPv4 requests received 2 requests with EDNS(0) received 2 responses sent 2 responses with EDNS(0) sent 2 queries resulted in successful answer 2 queries resulted in non authoritative answer 2 queries caused recursion 2 UDP queries received ++ Zone Maintenance Statistics ++ ++ Resolver Statistics ++ [Common] [View: tom] 98 IPv4 queries sent 59 IPv6 queries sent 98 IPv4 responses received 39 truncated responses received 98 query retries 8 IPv4 NS address fetches 8 IPv6 NS address fetches 5 IPv6 NS address fetch failed 46 queries with RTT 10-100ms 52 queries with RTT 100-500ms 31 bucket size 157 COOKIE send with client cookie only [View: dick] 31 bucket size [View: harry] 31 bucket size [View: _bind] 31 bucket size ++ Cache Statistics ++ [View: tom (Cache: foo)] 417 cache hits 27 cache misses 0 cache hits (from query) 3 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 99 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 64568 cache tree memory in use 64616 cache tree highest memory in use 393216 cache heap memory total 132096 cache heap memory in use 132096 cache heap highest memory in use [View: dick (Cache: foo)] [View: harry (Cache: foo)] [View: _bind (Cache: foo)] 0 cache hits 0 cache misses 0 cache hits (from query) 0 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 0 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 29712 cache tree memory in use 29712 cache tree highest memory in use 262144 cache heap memory total 1024 cache heap memory in use 1024 cache heap highest memory in use ++ Cache DB RRsets ++ [View: tom (Cache: foo)] 85 A 8 NS 2 CNAME 36 AAAA 2 DS 4 RRSIG 5 !AAAA [View: dick (Cache: foo)] [View: harry (Cache: foo)] [View: _bind (Cache: foo)] ++ ADB stats ++ [View: tom] 1021 Address hash table size 118 Addresses in hash table 1021 Name hash table size 98 Names in hash table [View: dick] 1021 Address hash table size 1021 Name hash table size [View: harry] 1021 Address hash table size 1021 Name hash table size [View: _bind] 1021 Address hash table size 1021 Name hash table size ++ Socket I/O Statistics ++ 118 UDP/IPv4 sockets opened 167 UDP/IPv6 sockets opened 64 TCP/IPv4 sockets opened 2 TCP/IPv6 sockets opened 1 Raw sockets opened 88 UDP/IPv4 sockets closed 164 UDP/IPv6 sockets closed 57 TCP/IPv4 sockets closed 164 UDP/IPv6 socket connect failures 88 UDP/IPv4 connections established 53 TCP/IPv4 connections established 5 TCP/IPv4 connections accepted 164 UDP/IPv6 send errors 30 UDP/IPv4 sockets active 3 UDP/IPv6 sockets active 16 TCP/IPv4 sockets active 2 TCP/IPv6 sockets active 1 Raw sockets active ++ Per Zone Query Statistics ++ --- Statistics Dump --- (1506437317) +++ Statistics Dump +++ (1506437535) ++ Incoming Requests ++ 2 QUERY ++ Incoming Queries ++ 2 A ++ Outgoing Rcodes ++ 2 NOERROR ++ Outgoing Queries ++ [View: tom] [View: dick] [View: harry] [View: foo] [View: _bind] ++ Name Server Statistics ++ 2 IPv4 requests received 2 requests with EDNS(0) received 2 responses sent 2 responses with EDNS(0) sent 2 queries resulted in successful answer 2 queries resulted in non authoritative answer 2 queries caused recursion 2 UDP queries received ++ Zone Maintenance Statistics ++ ++ Resolver Statistics ++ [Common] [View: tom] 31 bucket size [View: dick] 31 bucket size [View: harry] 31 bucket size [View: foo] 31 bucket size [View: _bind] 31 bucket size ++ Cache Statistics ++ [View: tom (Cache: foo)] 0 cache hits 0 cache misses 0 cache hits (from query) 0 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 0 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 29712 cache tree memory in use 29712 cache tree highest memory in use 262144 cache heap memory total 1024 cache heap memory in use 1024 cache heap highest memory in use [View: dick (Cache: foo)] [View: harry (Cache: foo)] [View: foo (Cache: foo)] [View: _bind (Cache: foo)] 0 cache hits 0 cache misses 0 cache hits (from query) 0 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 0 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 29712 cache tree memory in use 29712 cache tree highest memory in use 262144 cache heap memory total 1024 cache heap memory in use 1024 cache heap highest memory in use ++ Cache DB RRsets ++ [View: tom (Cache: foo)] [View: dick (Cache: foo)] [View: harry (Cache: foo)] [View: foo (Cache: foo)] [View: _bind (Cache: foo)] ++ ADB stats ++ [View: tom] 1021 Address hash table size 1021 Name hash table size [View: dick] 1021 Address hash table size 1021 Name hash table size [View: harry] 1021 Address hash table size 1021 Name hash table size [View: foo] 1021 Address hash table size 1021 Name hash table size [View: _bind] 1021 Address hash table size 1021 Name hash table size ++ Socket I/O Statistics ++ 118 UDP/IPv4 sockets opened 167 UDP/IPv6 sockets opened 64 TCP/IPv4 sockets opened 2 TCP/IPv6 sockets opened 1 Raw sockets opened 88 UDP/IPv4 sockets closed 164 UDP/IPv6 sockets closed 59 TCP/IPv4 sockets closed 164 UDP/IPv6 socket connect failures 88 UDP/IPv4 connections established 53 TCP/IPv4 connections established 7 TCP/IPv4 connections accepted 164 UDP/IPv6 send errors 30 UDP/IPv4 sockets active 3 UDP/IPv6 sockets active 18 TCP/IPv4 sockets active 2 TCP/IPv6 sockets active 1 Raw sockets active ++ Per Zone Query Statistics ++ --- Statistics Dump --- (1506437535) +++ Statistics Dump +++ (1506438246) ++ Incoming Requests ++ 3 QUERY ++ Incoming Queries ++ 3 A ++ Outgoing Rcodes ++ 3 NOERROR ++ Outgoing Queries ++ [View: tom] 32 A 15 NS 15 AAAA [View: dick] [View: harry] [View: foo] [View: _bind] ++ Name Server Statistics ++ 3 IPv4 requests received 3 requests with EDNS(0) received 3 responses sent 3 responses with EDNS(0) sent 3 queries resulted in successful answer 3 queries resulted in non authoritative answer 3 queries caused recursion 3 UDP queries received ++ Zone Maintenance Statistics ++ ++ Resolver Statistics ++ [Common] [View: tom] 16 IPv4 queries sent 46 IPv6 queries sent 16 IPv4 responses received 6 truncated responses received 52 query retries 1 IPv4 NS address fetches 1 IPv6 NS address fetches 7 queries with RTT 10-100ms 9 queries with RTT 100-500ms 31 bucket size 62 COOKIE send with client cookie only [View: dick] 31 bucket size [View: harry] 31 bucket size [View: foo] 31 bucket size [View: _bind] 31 bucket size ++ Cache Statistics ++ [View: tom (Cache: foo)] 67 cache hits 27 cache misses 0 cache hits (from query) 1 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 47 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 48768 cache tree memory in use 49080 cache tree highest memory in use 393216 cache heap memory total 132096 cache heap memory in use 132096 cache heap highest memory in use [View: dick (Cache: foo)] [View: harry (Cache: foo)] [View: foo (Cache: foo)] [View: _bind (Cache: foo)] 0 cache hits 0 cache misses 0 cache hits (from query) 0 cache misses (from query) 0 cache records deleted due to memory exhaustion 0 cache records deleted due to TTL expiration 0 cache database nodes 64 cache database hash buckets 287408 cache tree memory total 29712 cache tree memory in use 29712 cache tree highest memory in use 262144 cache heap memory total 1024 cache heap memory in use 1024 cache heap highest memory in use ++ Cache DB RRsets ++ [View: tom (Cache: foo)] 34 A 6 NS 32 AAAA 3 DS 5 RRSIG [View: dick (Cache: foo)] [View: harry (Cache: foo)] [View: foo (Cache: foo)] [View: _bind (Cache: foo)] ++ ADB stats ++ [View: tom] 1021 Address hash table size 65 Addresses in hash table 1021 Name hash table size 33 Names in hash table [View: dick] 1021 Address hash table size 1021 Name hash table size [View: harry] 1021 Address hash table size 1021 Name hash table size [View: foo] 1021 Address hash table size 1021 Name hash table size [View: _bind] 1021 Address hash table size 1021 Name hash table size ++ Socket I/O Statistics ++ 128 UDP/IPv4 sockets opened 213 UDP/IPv6 sockets opened 71 TCP/IPv4 sockets opened 2 TCP/IPv6 sockets opened 1 Raw sockets opened 98 UDP/IPv4 sockets closed 210 UDP/IPv6 sockets closed 67 TCP/IPv4 sockets closed 210 UDP/IPv6 socket connect failures 98 UDP/IPv4 connections established 59 TCP/IPv4 connections established 9 TCP/IPv4 connections accepted 210 UDP/IPv6 send errors 30 UDP/IPv4 sockets active 3 UDP/IPv6 sockets active 21 TCP/IPv4 sockets active 2 TCP/IPv6 sockets active 1 Raw sockets active ++ Per Zone Query Statistics ++ --- Statistics Dump --- (1506438246)