Report information
The Basics
Id:
46130
Status:
open
Priority:
Low/Low
Queue:
bind9-public
People
Owner:
Nobody in particular
Requestors:
Cc:
AdminCc:
BugTracker
Version Fixed:
(no value)
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
(no value)
Severity:
(no value)
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
feature
Dates
Created:Thu, 28 Sep 2017 15:12:28 -0400
Updated:Fri, 06 Oct 2017 03:09:09 -0400
Closed:Thu, 05 Oct 2017 16:22:12 -0400

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Thu, 28 Sep 2017 15:12:28 -0400 Mukund Sivaraman <muks@isc.org> - Ticket created
To: bind-suggest@isc.org
Date: Fri, 29 Sep 2017 00:42:16 +0530
From: "Mukund Sivaraman" <muks@isc.org>
Subject: Drop dependency on libxml2 and libjson

Statistics output is just text generation. It can be generated using an isc_buffer, which will also be smaller, tidier and readable code. Mukund
  Thu, 28 Sep 2017 15:18:28 -0400 Mukund Sivaraman <muks@isc.org> - Correspondence added
To: "Mukund Sivaraman via RT" <bind9-public@isc.org>
From: "Mukund Sivaraman" <muks@isc.org>
Date: Fri, 29 Sep 2017 00:48:20 +0530
Subject: Re: [ISC-Bugs #46130] Drop dependency on libxml2 and libjson

rt46130 is ready for 1st review. It drops dependency on libxml2. Windows build files and README.md need update, but I'll do that when removing libjson as a dependency. As part of this cleanup, I've noticed bugs that I've fixed but it is lost in the noise in the commit. 30 files changed, 474 insertions(+), 1241 deletions(-) Mukund
Thu, 28 Sep 2017 15:18:29 -0400 The RT System itself - Status changed from 'new' to 'open'
Thu, 28 Sep 2017 15:19:21 -0400 Mukund Sivaraman <muks@isc.org> - Status changed from 'open' to 'review'
  Thu, 28 Sep 2017 16:49:35 -0400 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Thu Sep 28 19:18:28 2017, muks wrote: > rt46130 is ready for 1st review. It drops dependency on libxml2. Windows > build files and README.md need update, but I'll do that when removing > libjson as a dependency. => please remember that libjson is not supported on Windows (cf Configure perl script tail comments).
  Thu, 28 Sep 2017 17:19:31 -0400 Mukund Sivaraman <muks@isc.org> - Correspondence added
To: "Francis Dupont via RT" <bind9-public@isc.org>
From: "Mukund Sivaraman" <muks@isc.org>
Date: Fri, 29 Sep 2017 02:49:23 +0530
Subject: Re: [ISC-Bugs #46130] Drop dependency on libxml2 and libjson

On Thu, Sep 28, 2017 at 08:49:36PM +0000, Francis Dupont via RT wrote: > On Thu Sep 28 19:18:28 2017, muks wrote: > > rt46130 is ready for 1st review. It drops dependency on libxml2. Windows > > build files and README.md need update, but I'll do that when removing > > libjson as a dependency. > > => please remember that libjson is not supported on Windows > (cf Configure perl script tail comments). Yes, the branch is about removing these dependencies from BIND (i.e., libxml2 and libjson are no longer used). Mukund
  Thu, 28 Sep 2017 22:44:40 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

> 16:58:28 ray@jabber.isc.org: it feels brittle, compared to using a > library that ensures that your tags get closed, and that all values > are correctly escaped > 16:58:43 bconry: when you use a library you're letting (supposed) > experts in the format make sure that your output will be legal > 16:59:07 bconry: when you roll your own you're trusting yourself and > all future maintainers to be expert enough in the format to not make > any mistakes > 16:59:10 ray@jabber.isc.org: last big project I worked on before ISC, > I insisted that the new version of the code use an existing JSON > library rather than hand-code it I agree with these objections. I think we can probably improve code readability by writing subsidiary functions that handle the opening and closing of tags, but I don't want to risk BIND producing improperly sanitized XML. I *love* isc_buffer_printf() though! Let's definitely keep that idea.
Thu, 05 Oct 2017 08:09:04 -0400 Michał Kępień <michal@isc.org> - Reference by #46201: Add isc_buffer_printf() added
  Thu, 05 Oct 2017 16:22:10 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

isc_buffer_printf() has been moved into another ticket now (46028) so I'll mark this one as rejected.
Thu, 05 Oct 2017 16:22:12 -0400 Evan Hunt <Evan_Hunt@isc.org> - Status changed from 'review' to 'rejected'
  Fri, 06 Oct 2017 03:09:08 -0400 Michał Kępień <michal@isc.org> - Correspondence added

Note for posterity to avoid confusion: if it is not already clear from the reference added to this ticket, isc_buffer_printf() is being discussed in RT #46201, not RT #46028 as suggested by the previous comment.
Fri, 06 Oct 2017 03:09:09 -0400 The RT System itself - Status changed from 'rejected' to 'open'