Report information
The Basics
Id:
46311
Status:
resolved
Priority:
Low/Low
Queue:
bind9-public
People
Owner:
Nobody in particular
Requestors:
Mark Andrews <marka@isc.org>
Cc:
AdminCc:
BugTracker
Version Fixed:
9.9.12, 9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S2 Normal
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
bug
Dates
Created:Wed, 18 Oct 2017 02:02:35 -0400
Updated:Thu, 19 Oct 2017 13:33:07 -0400
Closed:Wed, 18 Oct 2017 22:15:10 -0400

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Wed, 18 Oct 2017 02:02:36 -0400 Mark Andrews <marka@isc.org> - Ticket created
Subject: ISC_DEPRECATED shouldn't be in <isc/util.h>
From: marka@isc.org
Date: Tue, 17 Oct 2017 20:02:35 -1000
To: bind9-public@isc.org

% grep -r __attribute__ lib/isc/include/ lib/isc/include/isc/formatcheck.h:#define ISC_FORMAT_PRINTF(fmt, args) __attribute__((__format__(__printf__, fmt, args))) lib/isc/include/isc/platform.h:#define ISC_PLATFORM_NORETURN_POST __attribute__((noreturn)) lib/isc/include/isc/util.h:#define ISC_DEPRECATED __attribute__((deprecated)) % <isc/deprecated.h> would be much more appropriate. <isc/util.h> pulls in too much baggage for users of libisc, libdns etc.
Wed, 18 Oct 2017 03:30:15 -0400 Mark Andrews <marka@isc.org> - Reference by #46230: And and use isc_rng_randombytes() instead of combining two 16-bit values in various places added
Wed, 18 Oct 2017 03:30:53 -0400 Mark Andrews <marka@isc.org> - Status changed from 'new' to 'review'
Wed, 18 Oct 2017 03:30:53 -0400 Mark Andrews <marka@isc.org> - Priority P2 Normal added
Wed, 18 Oct 2017 03:30:53 -0400 Mark Andrews <marka@isc.org> - Severity S2 Normal added
Wed, 18 Oct 2017 03:30:53 -0400 Mark Andrews <marka@isc.org> - Area feature changed to bug
  Wed, 18 Oct 2017 03:33:24 -0400 Mark Andrews <marka@isc.org> - Correspondence added

Ready for review. Needed to also extract ISC_LIKELY and ISC_UNLIKELY. <isc/util.h> is no longer included in any header file with the exception of <isccc/uti.h> which serves a similar purpose.
  Wed, 18 Oct 2017 20:53:07 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

I updated it a little - likely.h wasn't being installed, and some C files still needed util.h added to them. Looks fine now.
Wed, 18 Oct 2017 20:53:07 -0400 Evan Hunt <Evan_Hunt@isc.org> - Given to Mark Andrews <marka@isc.org>
Wed, 18 Oct 2017 22:05:35 -0400 Mark Andrews <marka@isc.org> - Version Fixed 9.9.12, 9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.0 added
  Wed, 18 Oct 2017 22:05:36 -0400 Mark Andrews <marka@isc.org> - Correspondence added

4774. [bug] <isc/util.h> was incorrectly included in several header files. [RT #46311]
Wed, 18 Oct 2017 22:05:36 -0400 Mark Andrews <marka@isc.org> - Untaken
Wed, 18 Oct 2017 22:15:10 -0400 Mark Andrews <marka@isc.org> - Status changed from 'review' to 'resolved'
Thu, 19 Oct 2017 13:33:07 -0400 Thomas Markwalder <tmark@isc.org> - Reference by #46332: BIND9 include file changes cause implicit declaration errors for POST() and INSIST() added