Report information
The Basics
Id:
46230
Status:
resolved
Priority:
Low/Low
Queue:
bind9-public
People
Owner:
Mukund Sivaraman <muks@isc.org>
Requestors:
Cc:
AdminCc:
BugTracker
Version Fixed:
9.12.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P2 Normal
Severity:
S3 Low
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
feature
Dates
Created:Mon, 09 Oct 2017 07:52:46 -0400
Updated:Mon, 06 Nov 2017 13:45:44 -0500
Closed:Mon, 06 Nov 2017 13:45:44 -0500

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Mon, 09 Oct 2017 07:52:46 -0400 Mukund Sivaraman <muks@isc.org> - Ticket created
Subject: Use isc_rng_random32() instead of combining two 16-bit values in various places
To: bind-suggest@isc.org
From: "Mukund Sivaraman" <muks@isc.org>
Date: Mon, 9 Oct 2017 17:22:36 +0530

When the old isc_random_get() was replaced with isc_rng_random(), a function should have been created to return a 32-bit value than combining two 16-bit values in various parts of the code.
Mon, 09 Oct 2017 10:48:16 -0400 Mukund Sivaraman <muks@isc.org> - Status changed from 'new' to 'review'
Mon, 09 Oct 2017 10:48:16 -0400 Mukund Sivaraman <muks@isc.org> - Severity S3 Low added
Mon, 09 Oct 2017 10:48:16 -0400 Mukund Sivaraman <muks@isc.org> - Priority P1 High added
Mon, 09 Oct 2017 10:48:27 -0400 Mukund Sivaraman <muks@isc.org> - Priority P1 High changed to P2 Normal
  Wed, 18 Oct 2017 02:11:32 -0400 Mark Andrews <marka@isc.org> - Correspondence added

<isc/util.h> shouldn't be included in header files. I've opened a seperate ticket to create <isc/deprecated.h> and move ISC_DEPRECATED there. <isc/util.h> doesn't limit namespace changes to ISC_* which is fine if you want what is there but it shouldn't be forced on users.
Wed, 18 Oct 2017 03:30:15 -0400 Mark Andrews <marka@isc.org> - Reference to #46311: ISC_DEPRECATED shouldn't be in <isc/util.h> added
  Wed, 18 Oct 2017 21:05:10 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

On Wed Oct 18 06:11:32 2017, marka wrote: > <isc/util.h> shouldn't be included in header files. I've opened a > seperate ticket to create <isc/deprecated.h> and move > ISC_DEPRECATED there. Does that mean it's okay for Mukund to commit otherwise? I was going to suggest the ticket should be given to Ondrej so he can review the unit tests he asked for Mukund to add, but if you've reviewed them then it should be given to Mukund.
  Wed, 18 Oct 2017 23:15:28 -0400 Mark Andrews <marka@isc.org> - Correspondence added
Date: Thu, 19 Oct 2017 14:13:39 +1100
Subject: Re: [ISC-Bugs #46230] Use isc_rng_random32() instead of combining two 16-bit values in various places
To: bind9-public@isc.org
From: "Mark Andrews" <marka@isc.org>

In message <rt-4.4.1-41896-1508375110-140.46230-4-0@isc.org>, "Evan Hunt via RT " writes: > On Wed Oct 18 06:11:32 2017, marka wrote: > > <isc/util.h> shouldn't be included in header files. I've opened a > > seperate ticket to create <isc/deprecated.h> and move > > ISC_DEPRECATED there. > > Does that mean it's okay for Mukund to commit otherwise? > > I was going to suggest the ticket should be given to Ondrej so he can > review the unit tests he asked for Mukund to add, but if you've reviewed > them then it should be given to Mukund. We need to rebase off the updated master. > -- > Ticket History: https://bugs.isc.org/Ticket/Display.html?id=46230 -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org
  Mon, 23 Oct 2017 17:07:32 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

> We need to rebase off the updated master. ... why? This branch forked from master only two weeks ago.
  Mon, 23 Oct 2017 18:10:07 -0400 Mukund Sivaraman <muks@isc.org> - Correspondence added
From: "Mukund Sivaraman" <muks@isc.org>
To: "Evan Hunt via RT" <bind9-public@isc.org>
Subject: Re: [ISC-Bugs #46230] Use isc_rng_random32() instead of combining two 16-bit values in various places
Date: Tue, 24 Oct 2017 03:36:34 +0530

On Mon, Oct 23, 2017 at 09:07:32PM +0000, Evan Hunt via RT wrote: > > We need to rebase off the updated master. > > ... why? This branch forked from master only two weeks ago. I think he means we should get the branch working without including isc/util.h in a public header (random.h) for ISC_DEPRECATED. Mukund
  Sat, 28 Oct 2017 22:39:44 -0400 Mukund Sivaraman <muks@isc.org> - Correspondence added
Subject: Re: [ISC-Bugs #46230] Use isc_rng_random32() instead of combining two 16-bit values in various places
Date: Sun, 29 Oct 2017 08:09:14 +0530
From: "Mukund Sivaraman" <muks@isc.org>
To: "Mukund Sivaraman via RT" <bind9-public@isc.org>

Please review rt46230_2. Mukund
Sat, 28 Oct 2017 22:40:21 -0400 Mukund Sivaraman <muks@isc.org> - Subject changed from 'Use isc_rng_random32() instead of combining two 16-bit values in various places' to 'And and use isc_rng_randombytes() instead of combining two 16-bit values in various places'
  Tue, 31 Oct 2017 15:42:35 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

> Please review rt46230_2. I wasn't the original reviewer, but this looks fine to me.
Tue, 31 Oct 2017 15:42:36 -0400 Evan Hunt <Evan_Hunt@isc.org> - Given to Mukund Sivaraman <muks@isc.org>
  Mon, 06 Nov 2017 13:45:44 -0500 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

Merged, per Mukund's request. 4807. [cleanup] isc_rng_randombytes() returns a specified number of bytes from the PRNG; this is now used instead of calling isc_rng_random() multiple times. [RT #46230] 9.12.0
Mon, 06 Nov 2017 13:45:44 -0500 Evan Hunt <Evan_Hunt@isc.org> - Status changed from 'review' to 'resolved'
Mon, 06 Nov 2017 13:45:44 -0500 Evan Hunt <Evan_Hunt@isc.org> - Version Fixed 9.12.0 added