Report information
The Basics
Id:
46833
Status:
resolved
Priority:
Low/Low
Queue:
bind9-public
People
Owner:
Nobody in particular
Requestors:
Francis Dupont <Francis_Dupont@isc.org>
Cc:
AdminCc:
BugTracker
Version Fixed:
9.9.12, 9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.1
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P1 High
Severity:
S3 Low
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
feature
Attachments
fix-atf_tp_get_tcs.patch
Dates
Created:Mon, 11 Dec 2017 08:39:38 -0500
Updated:Mon, 18 Dec 2017 17:02:51 -0500
Closed:Mon, 18 Dec 2017 17:02:26 -0500

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Mon, 11 Dec 2017 08:39:38 -0500 Francis Dupont <Francis_Dupont@isc.org> - Ticket created
Date: Mon, 11 Dec 2017 13:39:38 +0000
Subject: Warning in embedded atf code
To: bind9-public@isc.org
From: Francis_Dupont@isc.org

ISC DHCP builds show it so they are in v9_11 branch but according to diff master has exactly the same code: Building ATF support atf-c/detail/tp_main.c:288:10: warning: passing 'const atf_tc_t *const *' (aka 'const struct atf_tc *const *') to parameter of type 'void *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] free(tcs); ^~~ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/stdlib.h:151:18: note: passing argument to parameter here void free(void *); ^ 1 warning generated. I suggest a cast.
  Mon, 11 Dec 2017 08:48:25 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Mon Dec 11 13:39:38 2017, fdupont wrote: > I suggest a cast. => tried: a deconst is required.
Mon, 11 Dec 2017 08:48:25 -0500 Francis Dupont <Francis_Dupont@isc.org> - Taken
  Mon, 11 Dec 2017 08:53:42 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

Patch ready for review. I put a high priority as ISC DHCP alpha is for today.
Mon, 11 Dec 2017 08:53:43 -0500 Francis Dupont <Francis_Dupont@isc.org> - Status changed from 'open' to 'review'
Mon, 11 Dec 2017 08:53:43 -0500 Francis Dupont <Francis_Dupont@isc.org> - Severity S3 Low added
Mon, 11 Dec 2017 08:53:43 -0500 Francis Dupont <Francis_Dupont@isc.org> - Priority P1 High added
  Mon, 11 Dec 2017 16:00:29 -0500 Mark Andrews <marka@isc.org> - Correspondence added
To: bind9-public@isc.org
Subject: Re: [ISC-Bugs #46833] Warning in embedded atf code
From: "Mark Andrews" <marka@isc.org>
Date: Tue, 12 Dec 2017 08:00:23 +1100

The return from atf_tp_get_tcs() should be declared "const atf_tc_t **” rather then "const atf_tc_t *const*”. There is zero reason for the extra const. tcs also need a similar adjustment > On 12 Dec 2017, at 12:39 am, Francis Dupont via RT <bind9-public@isc.org> wrote: > > > Mon Dec 11 13:39:38 2017: Request 46833 was acted upon. > Transaction: Ticket created by fdupont > Queue: bind9-public > Subject: Warning in embedded atf code > Owner: Nobody > Requestors: Francis_Dupont@isc.org > Status: open > Ticket <URL: https://bugs.isc.org/Ticket/Display.html?id=46833 > > ----------------------------------------------------------------------- > > ISC DHCP builds show it so they are in v9_11 branch > but according to diff master has exactly the same code: > > Building ATF support > atf-c/detail/tp_main.c:288:10: warning: passing 'const atf_tc_t *const *' (aka 'const struct atf_tc *const *') to parameter of type 'void *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] > free(tcs); > ^~~ > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/stdlib.h:151:18: note: passing argument to parameter here > void free(void *); > ^ > 1 warning generated. > > I suggest a cast. > -- Mark Andrews, ISC 1 Seymour St., Dundas Valley, NSW 2117, Australia PHONE: +61 2 9871 4742 INTERNET: marka@isc.org
fix-atf_tp_get_tcs.patch

Message body not shown because it is not plain text.


  Thu, 14 Dec 2017 18:56:01 -0500 Mark Andrews <marka@isc.org> - Correspondence added

While I believe the prototype should be changed (I've submitted a merge request to that effect upstream) we should be consistent with the rest of the atf code and use UNCONST as is done elsewhere in the tree. I've updated the branch to do so. It should be good to commit.
  Mon, 18 Dec 2017 10:20:37 -0500 Francis Dupont <Francis_Dupont@isc.org> - Correspondence added

On Thu Dec 14 23:56:01 2017, marka wrote: > It should be good to commit. => merged to master, v9_12, v9_11, v9_10 and v9_9.
Mon, 18 Dec 2017 10:20:38 -0500 Francis Dupont <Francis_Dupont@isc.org> - Given to Mark Andrews <marka@isc.org>
Mon, 18 Dec 2017 17:02:25 -0500 Mark Andrews <marka@isc.org> - Version Fixed 9.9.12, 9.9.12(sub), 9.10.7, 9.10.7(sub), 9.11.3, 9.12.1 added
  Mon, 18 Dec 2017 17:02:25 -0500 Mark Andrews <marka@isc.org> - Correspondence added

Fixed embedded atf code warning (RT 46833) No CHANGES note.
Mon, 18 Dec 2017 17:02:26 -0500 Mark Andrews <marka@isc.org> - Status changed from 'review' to 'resolved'
Mon, 18 Dec 2017 17:02:51 -0500 Mark Andrews <marka@isc.org> - Untaken