Bug #46841 for bind9-public: New Defects reported by Coverity Scan for BIND

Hi, Please find the latest report on new defect(s) introduced to BIND found with Coverity Scan. 2 new defect(s) introduced to BIND found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1426087: Control flow issues (DEADCODE) /lib/ns/tests/query_test.c: 60 in ns__query_sfcache_test() ________________________________________________________________________________________________________ *** CID 1426087: Control flow issues (DEADCODE) /lib/ns/tests/query_test.c: 60 in ns__query_sfcache_test() 54 REQUIRE(test->cache_entry_present == ISC_TRUE || 55 test->cache_entry_flags == 0); 56 57 /* 58 * Interrupt execution if query_done() is called. 59 */ >>> CID 1426087: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "query_hooks[query_hooks@dim...". 60 ns_hook_t query_hooks[NS_QUERY_HOOKS_COUNT] = { 61 [NS_QUERY_DONE_BEGIN] = { 62 .callback = ns_test_hook_catch_call, 63 .callback_data = NULL, 64 }, 65 }; ** CID 1426086: Control flow issues (DEADCODE) /lib/ns/tests/query_test.c: 267 in ns__query_start_test() ________________________________________________________________________________________________________ *** CID 1426086: Control flow issues (DEADCODE) /lib/ns/tests/query_test.c: 267 in ns__query_start_test() 261 (test->auth_zone_origin != NULL && 262 test->auth_zone_path != NULL)); 263 264 /* 265 * Interrupt execution if query_lookup() or query_done() is called. 266 */ >>> CID 1426086: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "query_hooks[query_hooks@dim...". 267 ns_hook_t query_hooks[NS_QUERY_HOOKS_COUNT] = { 268 [NS_QUERY_LOOKUP_BEGIN] = { 269 .callback = ns_test_hook_catch_call, 270 .callback_data = NULL, 271 }, 272 [NS_QUERY_DONE_BEGIN] = { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRatftY8JjD0XUVeK0eDwSEPh4vRqywf0w3swJ8N5sF82Q-3D-3D_QjBaZtEJDFdtBJj3YWWx4OwxXn6h7X1bCFA-2BmidshrgROp-2FZB5XLa-2FWMt7e0Dnc2DFiS2bIxzej3MpwjhxblKsEZwwDr4FH31xZBvxHwSzMZ3ngEueM2aJ0C2o9N3OaAkT7u1f0gv0IlQ-2Frm-2BCyzPNMIjG8JTJqK4u1rKnQf6aST6PBcLza4nLEzTZ5F-2FgFQ7HuKFwbhivL-2FaPPqR33Ceg-3D-3D To manage Coverity Scan email notifications for "bind9-bugs@isc.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4rIy41Xs74BznZj4k3EIh0OhIeqrl4tMKvZau-2B5LUEdCBSWjNYx5kf-2B92zKd1nnWiMMfay-2Fg7DuBn2-2BCqidUp9Y39BJMi1Fd-2FeSXcvFgX1I4-3D_QjBaZtEJDFdtBJj3YWWx4OwxXn6h7X1bCFA-2BmidshrgROp-2FZB5XLa-2FWMt7e0Dnc2cdJe2kViWAyRe1dLQjEkb-2Fs9bz7-2B-2FgdtneYj5UigTxIsEmMh6fvKr08w-2FnJb-2FKbippSeV8rNFJpR8K9W3dALD8FIRkdRLrI1ewKJT-2BuCRrM3H4QBUToiN4otvLduYx0HQsJj0MthPbFVysgfzsIwFg-3D-3D

---

Coverity is trying each enum value and the final index value is out of range of the array indexes give C is zero based. -- Mark Andrews

---

We could also just mark these as intentional and ignore them.

---

Thank you for this, it does shed some light on these warnings. So it complains that if I declare an array the way I do and then, somewhere else, I attempt to access the element at index NS_QUERY_HOOKS_COUNT (which I never do, but Coverity does not know that), it will be out-of-bounds? If that is the case, I would just size the arrays using the original enum value (NS_QUERY_HOOKS_COUNT) + 1, i.e. without renaming the last enum value.

---