Report information
The Basics
Id:
46859
Status:
resolved
Estimated:
1.5 hours (90 minutes)
Worked:
1 hour (60 minutes)
Users:
tmark: 1 hour (60 minutes)
Priority:
Low/Low
Queue:

People
Requestors:
Cc:
AdminCc:

BugTracker
Version Fixed:
4.4.0 4.3.7 4.1-ESV-R16
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
4.4.0 4.3.7 4.1-ESV-R16
Priority:
(no value)
Severity:
(no value)
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
(no value)
Area:
bug

Dates
Created:Fri, 15 Dec 2017 17:04:16 -0500
Updated:Thu, 21 Dec 2017 15:59:49 -0500
Closed:Thu, 21 Dec 2017 15:59:49 -0500



This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

From: mcnally@isc.org
Subject: dhcpd.conf lease-file-name vs -lf argument
Date: Fri, 15 Dec 2017 22:04:16 +0000
To: dhcp-suggest@isc.org
A customer asked: > Dhcpd documentation states that the 'lf' argument takes precedence over > the 'lease-file-name' configuration option. > However, that doesn't seem to be correct. > > From man pages: > "Furthermore, it has no effect if overridden by the -lf flag or the > PATH_DHCPD_DB environment variable." > > From the code, the lease-file-name option is evaluated in > postconf_initialization() after the arguments are processed and > path_dhcpd_db will end up with the value defined in the option. > > What should be the correct expected behavior? Probably the correct behavior was meant to be as documented, but given that many releases have taken place without correcting the undocumented behavior, perhaps we should leave as is as correct the documentation at this point. Per support ticket #12117 that would be acceptable to the customer. So.. can we update the documentation to match the code's behavior? -mcnally.
On Mon Dec 18 16:33:20 2017, tmark wrote: > Ticket is ready for review. => the code fix is OK even it will be fine IMHO to change the no_dhcpd_xxx into have_dhcpd_xxx to reflect their real meanings. I have some concerns about the manual: - if by path you mean the result of dirname you should add "directory", i.e.: the absolute path and file name -> the absolute directory path and file name Note this stays against usage: this is named the absolute path. - in the precedence: lease-file-name -> lease-file-name configuration file statement -lf flag -> -lf command line flag - the requirement about the path can't be understood. More, I don't think it is true: the only constraint is the statement value must be an absolute path so it can be evaluated and opened after the chdir("/").
On Tue Dec 19 19:13:04 2017, tmark wrote: > Please pull and review. => done. I did some improvements in the manual: please pull, review and merge.
On Tue Dec 19 21:28:46 2017, tmark wrote: > committed to: > > master : 4.4.0-dev: > git# ab77c8b8b58ae5741482886c74515d8c0772a92b > > v4_3 : 4.3.6 > git# 39cf39b7fd15605a1245f61fef6b64ba78039342 > > v4_1_esv : 4.1-ESV-R15 : > git# defa417cf8cc95750da2904c8abde8d197e44470 Ticket is complete.