Report information
The Basics
Id:
46289
Status:
resolved
Priority:
Low/Low
Queue:
bind9-public
People
BugTracker
Version Fixed:
9.9.12, 9.10.7, 9.11.3, 9.12.0
Version Found:
(no value)
Versions Affected:
(no value)
Versions Planned:
(no value)
Priority:
P3 Low
Severity:
S3 Low
CVSS Score:
(no value)
CVE ID:
(no value)
Component:
BIND Common
Area:
libdns
Dates
Created:Mon, 16 Oct 2017 08:37:39 -0400
Updated:Wed, 25 Oct 2017 04:13:33 -0400
Closed:Wed, 25 Oct 2017 04:13:33 -0400

This bug tracker is no longer active.

Please go to our Gitlab to submit issues (both feature requests and bug reports) for active projects maintained by Internet Systems Consortium (ISC).

Due to security and confidentiality requirements, full access is limited to the primary maintainers.

History
  Mon, 16 Oct 2017 08:37:39 -0400 Michał Kępień <michal@isc.org> - Ticket created
From: michal@isc.org
To: bind9-public@isc.org
Subject: Make nsec3param_salt_totext() part of public libdns API
Date: Mon, 16 Oct 2017 14:37:39 +0200

While it is currently only used in lib/dns/zone.c, function nsec3param_salt_totext() may be considered generally useful, so move it to lib/dns/rdata/generic/nsec3param_51.c.
  Mon, 16 Oct 2017 08:40:56 -0400 Michał Kępień <michal@isc.org> - Correspondence added

Branch rt46289 makes nsec3param_salt_totext() a public libdns function and adds unit tests for it. Please review.
Mon, 16 Oct 2017 08:40:56 -0400 Michał Kępień <michal@isc.org> - Status changed from 'open' to 'review'
Mon, 16 Oct 2017 08:40:56 -0400 Michał Kępień <michal@isc.org> - Untaken
  Tue, 17 Oct 2017 23:28:42 -0400 Mark Andrews <marka@isc.org> - Correspondence added

Made a few updates. Ready to commit. Note we are theoretically feature frozen for 9.12.
Tue, 17 Oct 2017 23:29:42 -0400 Mark Andrews <marka@isc.org> - Given to Michał Kępień <michal@isc.org>
  Wed, 18 Oct 2017 01:26:20 -0400 Evan Hunt <each@isc.org> - Correspondence added
CC:
Subject: Re: [ISC-Bugs #46289] Make nsec3param_salt_totext() part of public libdns API
From: "Evan Hunt" <each@isc.org>
Date: Wed, 18 Oct 2017 05:26:17 +0000
To: "Mark Andrews via RT" <bind9-public@isc.org>

On Wed, Oct 18, 2017 at 03:28:43AM +0000, Mark Andrews via RT wrote: > Made a few updates. > > Ready to commit. Note we are theoretically feature frozen for 9.12. I'd call this [cleanup] not [func], it's not in any way a user-visible change. To quibble, I'd suggest moving it to lib/dns/nsec3.c and calling the function dns_nsec3param_salttotext(). The files in lib/dns/rdata are referenced via #include in code.c and called from lib/dns/rdata.c; it isn't a good fit to mix other stuff there.
  Fri, 20 Oct 2017 07:20:14 -0400 Michał Kępień <michal@isc.org> - Correspondence added

> I'd call this [cleanup] not [func], it's not in any way a user-visible > change. Agreed. Is this already annotated as [func] anywhere? rt46289 does not seem to include a CHANGES update. Did you just mean to point this out _before_ CHANGES is updated? > To quibble, I'd suggest moving it to lib/dns/nsec3.c and calling the > function dns_nsec3param_salttotext(). The files in lib/dns/rdata are > referenced via #include in code.c and called from lib/dns/rdata.c; it > isn't a good fit to mix other stuff there. Good point. I think I originally put it into lib/dns/rdata because that is what Mukund suggested in passing on Jabber and I have not bothered to look around the tree for a better fit. The changes I just pushed to rt46289 address your comments, merge nsec3param_test.c into nsec3_test.c and do some naming bikeshedding. No functional changes were introduced. Please review.
Fri, 20 Oct 2017 07:20:14 -0400 Michał Kępień <michal@isc.org> - Untaken
  Fri, 20 Oct 2017 13:29:19 -0400 Evan Hunt <each@isc.org> - Correspondence added
Date: Fri, 20 Oct 2017 17:29:18 +0000
CC:
Subject: Re: [ISC-Bugs #46289] Make nsec3param_salt_totext() part of public libdns API
To: "Michał Kępień via RT" <bind9-public@isc.org>
From: "Evan Hunt" <each@isc.org>

On Fri, Oct 20, 2017 at 11:20:14AM +0000, Michał Kępień via RT wrote: > Agreed. Is this already annotated as [func] anywhere? rt46289 does not > seem to include a CHANGES update. Did you just mean to point this out > _before_ CHANGES is updated? Yes. I meant there was no reason it needed to be committed before beta.
  Mon, 23 Oct 2017 17:00:27 -0400 Evan Hunt <Evan_Hunt@isc.org> - Correspondence added

This looks fine.
Mon, 23 Oct 2017 17:00:28 -0400 Evan Hunt <Evan_Hunt@isc.org> - Given to Michał Kępień <michal@isc.org>
  Wed, 25 Oct 2017 04:13:32 -0400 Michał Kępień <michal@isc.org> - Correspondence added

4787. [cleanup] Turn nsec3param_salt_totext() into a public function, dns_nsec3param_salttotext(), and add unit tests for it. [RT #46289] 9.9.12, 9.10.7, 9.11.3, 9.12.0
Wed, 25 Oct 2017 04:13:33 -0400 Michał Kępień <michal@isc.org> - Status changed from 'review' to 'resolved'
Wed, 25 Oct 2017 04:13:33 -0400 Michał Kępień <michal@isc.org> - Version Fixed 9.9.12, 9.10.7, 9.11.3, 9.12.0 added